Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Unified Diff: Source/core/css/StylePropertySerializer.cpp

Issue 879443006: Remove isInternalProperty (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/build/scripts/make_css_property_names.py ('k') | Source/core/css/StylePropertySet.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/StylePropertySerializer.cpp
diff --git a/Source/core/css/StylePropertySerializer.cpp b/Source/core/css/StylePropertySerializer.cpp
index d59e764ef6661f0c71257e8687ac2cc077ed1ef7..e5098788c458cd9dba198537d6e18f4c7daf2d3c 100644
--- a/Source/core/css/StylePropertySerializer.cpp
+++ b/Source/core/css/StylePropertySerializer.cpp
@@ -111,9 +111,6 @@ bool StylePropertySerializer::StylePropertySetForSerializer::shouldProcessProper
// and so on) either.
if (isShorthandProperty(propertyID) || propertyID == CSSPropertyAll)
return false;
- // We should not serialize internal properties.
- if (isInternalProperty(propertyID))
- return false;
// The all property is a shorthand that resets all CSS properties except
// direction and unicode-bidi. It only accepts the CSS-wide keywords.
@@ -203,8 +200,8 @@ String StylePropertySerializer::asText() const
StylePropertySerializer::PropertyValueForSerializer property = m_propertySet.propertyAt(n);
CSSPropertyID propertyID = property.id();
- // Only enabled or internal properties should be part of the style.
- ASSERT(CSSPropertyMetadata::isEnabledProperty(propertyID) || isInternalProperty(propertyID));
+ // Only enabled properties should be part of the style.
+ ASSERT(CSSPropertyMetadata::isEnabledProperty(propertyID));
CSSPropertyID shorthandPropertyID = CSSPropertyInvalid;
CSSPropertyID borderFallbackShorthandProperty = CSSPropertyInvalid;
String value;
« no previous file with comments | « Source/build/scripts/make_css_property_names.py ('k') | Source/core/css/StylePropertySet.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698