[turbofan] Don't embed pointer to builtins object in generic lowering.

[turbofan] Don't embed pointer to builtins object in generic lowering.

Accessing the builtins object this way prevents sharing of code across
native contexts; instead we now load the builtin from the context of the
JS operation instead.

R=mstarzinger@chromium.org

Committed: https://crrev.com/005343cfe6f030346f481c49bb85a3338114bd32
Cr-Commit-Position: refs/heads/master@{#26264}

[Benedikt Meurer, 2015-01-26 09:21:37]

PTAL

[Michael Starzinger, 2015-01-26 09:43:33]

LGTM.

https://codereview.chromium.org/879433002/diff/1/src/compiler/js-generic-lowe...
File src/compiler/js-generic-lowering.cc (right):

https://codereview.chromium.org/879433002/diff/1/src/compiler/js-generic-lowe...
src/compiler/js-generic-lowering.cc:191: CHECK(effect->op()->EffectOutputCount()
> 0);
nit: Can we at least turn this into a DCHECK?

[Benedikt Meurer, 2015-01-26 09:50:19]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2015-01-26 09:50:33]

https://codereview.chromium.org/879433002/diff/1/src/compiler/js-generic-lowe...
File src/compiler/js-generic-lowering.cc (right):

https://codereview.chromium.org/879433002/diff/1/src/compiler/js-generic-lowe...
src/compiler/js-generic-lowering.cc:191: CHECK(effect->op()->EffectOutputCount()
> 0);
On 2015/01/26 09:43:33, Michael Starzinger wrote:
> nit: Can we at least turn this into a DCHECK?

Done.

[commit-bot: I haz the power, 2015-01-26 09:51:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/879433002/20001

[commit-bot: I haz the power, 2015-01-26 10:20:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-26 10:20:55]

Patchset 2 (id:??) landed as
https://crrev.com/005343cfe6f030346f481c49bb85a3338114bd32
Cr-Commit-Position: refs/heads/master@{#26264}