Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Side by Side Diff: Source/core/frame/DOMWindowProperty.cpp

Issue 879423003: Move Location to DOMWindow (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google, Inc. All Rights Reserved. 2 * Copyright (C) 2011 Google, Inc. All Rights Reserved.
3 * Copyright (C) 2012 Apple Inc. All Rights Reserved. 3 * Copyright (C) 2012 Apple Inc. All Rights Reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
11 * notice, this list of conditions and the following disclaimer in the 11 * notice, this list of conditions and the following disclaimer in the
12 * documentation and/or other materials provided with the distribution. 12 * documentation and/or other materials provided with the distribution.
13 * 13 *
14 * THIS SOFTWARE IS PROVIDED BY GOOGLE INC. ``AS IS'' AND ANY 14 * THIS SOFTWARE IS PROVIDED BY GOOGLE INC. ``AS IS'' AND ANY
15 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 15 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
16 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 16 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
17 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR 17 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
18 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 18 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
19 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 19 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
20 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 20 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
21 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 21 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
22 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 22 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
23 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 23 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
24 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 24 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
25 */ 25 */
26 26
27 #include "config.h" 27 #include "config.h"
28 #include "core/frame/DOMWindowProperty.h" 28 #include "core/frame/DOMWindowProperty.h"
29 29
30 #include "core/frame/LocalDOMWindow.h" 30 #include "core/frame/DOMWindow.h"
31 #include "core/frame/Frame.h"
31 #include "core/frame/LocalFrame.h" 32 #include "core/frame/LocalFrame.h"
32 33
33 namespace blink { 34 namespace blink {
34 35
35 DOMWindowProperty::DOMWindowProperty(LocalFrame* frame) 36 DOMWindowProperty::DOMWindowProperty(Frame* frame)
36 : m_frame(frame) 37 : m_frame(frame)
37 #if !ENABLE(OILPAN) 38 #if !ENABLE(OILPAN)
38 , m_associatedDOMWindow(nullptr) 39 , m_associatedDOMWindow(nullptr)
39 #endif 40 #endif
40 { 41 {
41 // FIXME: For now it *is* acceptable for a DOMWindowProperty to be created w ith a null frame. 42 // FIXME: For now it *is* acceptable for a DOMWindowProperty to be created w ith a null frame.
42 // See fast/dom/navigator-detached-no-crash.html for the recipe. 43 // See fast/dom/navigator-detached-no-crash.html for the recipe.
43 // We should fix that. <rdar://problem/11567132> 44 // We should fix that. <rdar://problem/11567132>
44 if (m_frame) { 45 if (m_frame) {
45 // FIXME: Need to figure out what to do with DOMWindowProperties on 46 // FIXME: Need to figure out what to do with DOMWindowProperties on
46 // remote DOM windows. 47 // remote DOM windows.
47 #if ENABLE(OILPAN) 48 #if ENABLE(OILPAN)
48 m_frame->localDOMWindow()->registerProperty(this); 49 m_frame->domWindow()->registerProperty(this);
49 #else 50 #else
50 m_associatedDOMWindow = m_frame->localDOMWindow(); 51 m_associatedDOMWindow = m_frame->domWindow();
51 m_associatedDOMWindow->registerProperty(this); 52 m_associatedDOMWindow->registerProperty(this);
52 #endif 53 #endif
53 } 54 }
54 } 55 }
55 56
56 #if !ENABLE(OILPAN) 57 #if !ENABLE(OILPAN)
57 DOMWindowProperty::~DOMWindowProperty() 58 DOMWindowProperty::~DOMWindowProperty()
58 { 59 {
59 if (m_associatedDOMWindow) 60 if (m_associatedDOMWindow)
60 m_associatedDOMWindow->unregisterProperty(this); 61 m_associatedDOMWindow->unregisterProperty(this);
(...skipping 21 matching lines...) Expand all
82 { 83 {
83 // If the property is getting this callback it must have been 84 // If the property is getting this callback it must have been
84 // created with a LocalFrame and it should still have it. 85 // created with a LocalFrame and it should still have it.
85 ASSERT(m_frame); 86 ASSERT(m_frame);
86 #if !ENABLE(OILPAN) 87 #if !ENABLE(OILPAN)
87 // Ditto for its associated LocalDOMWindow. 88 // Ditto for its associated LocalDOMWindow.
88 ASSERT(m_associatedDOMWindow); 89 ASSERT(m_associatedDOMWindow);
89 #endif 90 #endif
90 } 91 }
91 92
93 LocalFrame* DOMWindowProperty::localFrame() const
94 {
95 if (m_frame && m_frame->isLocalFrame())
dcheng 2015/02/02 19:27:52 I think it's better to unconditionally toLocalFram
96 return toLocalFrame(m_frame);
97 return nullptr;
98 }
99
92 void DOMWindowProperty::trace(Visitor* visitor) 100 void DOMWindowProperty::trace(Visitor* visitor)
93 { 101 {
94 visitor->trace(m_frame); 102 visitor->trace(m_frame);
95 } 103 }
96 104
97 } // namespace blink 105 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698