Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 879403005: [ServiceWorker] Tests for Clients.openWindow(). (Closed)

Created:
5 years, 10 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 10 months ago
CC:
dominicc (has gone to gerrit), blink-reviews, falken, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/blink.git@window_interaction_tests
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[ServiceWorker] Tests for Clients.openWindow(). This is test has to live in the chromium/ directory because it is using testRunner. This is also introducing a small helper file that is being used by three tests and another one soon to come. BUG=437151 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190224

Patch Set 1 #

Patch Set 2 : no-find-copies #

Patch Set 3 : #

Patch Set 4 : test error types #

Patch Set 5 : cleanup and add test helper #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -92 lines) Patch
A LayoutTests/http/tests/serviceworker/chromium/clients-openwindow.html View 1 2 3 4 1 chunk +68 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/serviceworker/chromium/resources/clients-openwindow.js View 1 2 3 4 1 chunk +56 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/chromium/resources/notificationclick-can-focus.js View 1 2 3 4 6 chunks +14 lines, -47 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/chromium/resources/notificationclick-can-openwindow.js View 1 2 3 4 6 chunks +14 lines, -45 lines 0 comments Download
A LayoutTests/http/tests/serviceworker/chromium/resources/sw-test-helpers.js View 1 2 3 4 1 chunk +72 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
mlamouri (slow - plz ping)
5 years, 10 months ago (2015-02-05 20:59:09 UTC) #2
mlamouri (slow - plz ping)
Moving review to michaeln@ given that dominicc@ will unlikely be available until next weex.
5 years, 10 months ago (2015-02-06 12:05:24 UTC) #4
philipj_slow
I guess this is where tests for invalid URL case in ServiceWorkerClients::openWindow should go.
5 years, 10 months ago (2015-02-11 02:42:30 UTC) #5
mlamouri (slow - plz ping)
On 2015/02/11 at 02:42:30, philipj wrote: > I guess this is where tests for invalid ...
5 years, 10 months ago (2015-02-11 13:17:03 UTC) #6
mlamouri (slow - plz ping)
Dominic, I have updated the tests and included the helper you wanted me to use. ...
5 years, 10 months ago (2015-02-13 12:04:26 UTC) #8
dominicc (has gone to gerrit)
lgtm
5 years, 10 months ago (2015-02-16 06:55:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879403005/80001
5 years, 10 months ago (2015-02-16 06:56:21 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-16 06:59:52 UTC) #12
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190224

Powered by Google App Engine
This is Rietveld 408576698