Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: net/base/net_log_util.cc

Issue 879383004: Workaround for chrome://net-internals debug crash on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/net_log_util.cc
diff --git a/net/base/net_log_util.cc b/net/base/net_log_util.cc
index 75be128851425df39202c8ab91a839427e28904d..a623abfbfaeb5c9d99baeadd245a553b7aa58884 100644
--- a/net/base/net_log_util.cc
+++ b/net/base/net_log_util.cc
@@ -537,7 +537,8 @@ NET_EXPORT void CreateNetLogEntriesForActiveObjects(
// May only be called on the context's thread.
DCHECK(context->CalledOnValidThread());
// Contexts should all be using the same NetLog.
- DCHECK_EQ((*contexts.begin())->net_log(), context->net_log());
+ // TODO(mmenke) This DCHECK fails on Android.
jeremyim 2015/01/28 22:12:04 Alternatively, this could be wrapped with #if !de
+ // DCHECK_EQ((*contexts.begin())->net_log(), context->net_log());
mmenke 2015/01/30 15:17:14 Outputting requests from two different NetLogs (Or
jeremyim 2015/01/30 15:48:07 Done.
for (const auto& request : *context->url_requests()) {
requests.push_back(request);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698