Introduce optional 'bool shared' parameter to ServerSocket.bind() ...

dart/sdk/lib/io/socket.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart.io;
 
 
 /**
  * [InternetAddressType] is the type an [InternetAddress]. Currently,
  * IP version 4 (IPv4) and IP version 6 (IPv6) are supported.
@@ skipping 209 matching lines @@
    * using the [:port:] getter.
    *
    * The optional argument [backlog] can be used to specify the listen
    * backlog for the underlying OS listen setup. If [backlog] has the
    * value of [:0:] (the default) a reasonable value will be chosen by
    * the system.
    */
   external static Future<RawServerSocket> bind(address,
                                                int port,
                                                {int backlog: 0,
-                                                bool v6Only: false});
+                                                bool v6Only: false,
+                                                bool shared: false});
 
   /**
    * Returns the port used by this socket.
    */
   int get port;
 
   /**
    * Returns the address used by this socket.
    */
   InternetAddress get address;
@@ skipping 12 matching lines @@
    *
    * The returned [RawServerSocketReference] can be used to create other
    * [RawServerSocket]s listening on the same port,
    * using [RawServerSocketReference.create].
    * Incoming connections on the port will be distributed fairly between the
    * active server sockets.
    * The [RawServerSocketReference] can be distributed to other isolates through
    * a [RawSendPort].
    */
   RawServerSocketReference get reference;
+
+  /**
+   * Whether the underlying socket of this [RawServerSocket] might potentially
+   * be shared.
+   */
+  bool get shared;

[Søren Gjesse, 2015/01/29 09:05:51]

Do we need to expose this as a public getter?

[kustermann, 2015/01/29 11:14:05]

No. I've removed it now. We can add it later on again if there is a need for it.

 }
 
 
 /**
  * A [RawServerSocketReference].
  *
  * WARNING: This class is used with [RawServerSocket.reference] which is highly
  * experimental.
  */
 abstract class RawServerSocketReference {
@@ skipping 38 matching lines @@
    * [port] getter.
    *
    * The optional argument [backlog] can be used to specify the listen
    * backlog for the underlying OS listen setup. If [backlog] has the
    * value of [:0:] (the default) a reasonable value will be chosen by
    * the system.
    */
   external static Future<ServerSocket> bind(address,
                                             int port,
                                             {int backlog: 0,
-                                             bool v6Only: false});
+                                             bool v6Only: false,
+                                             bool shared: false});
 
   /**
    * Returns the port used by this socket.
    */
   int get port;
 
   /**
    * Returns the address used by this socket.
    */
   InternetAddress get address;
@@ skipping 12 matching lines @@
    *
    * The returned [ServerSocketReference] can be used to create other
    * [ServerSocket]s listening on the same port,
    * using [ServerSocketReference.create].
    * Incoming connections on the port will be distributed fairly between the
    * active server sockets.
    * The [ServerSocketReference] can be distributed to other isolates through a
    * [SendPort].
    */
   ServerSocketReference get reference;
+
+  /**
+   * Whether the underlying socket of this [ServerSocket] might potentially
+   * be shared.
+   */
+  bool get shared;

[Søren Gjesse, 2015/01/29 09:05:51]

Ditto.

[kustermann, 2015/01/29 11:14:05]

Done.

 }
 
 
 /**
  * A [ServerSocketReference].
  *
  * WARNING: This class is used with [ServerSocket.reference] which is highly
  * experimental.
  */
 abstract class ServerSocketReference {
@@ skipping 376 matching lines @@
     }
     if (address != null) {
       sb.write(", address = ${address.host}");
     }
     if (port != null) {
       sb.write(", port = $port");
     }
     return sb.toString();
   }
 }