Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 879343004: mac: Followup to ZERO_AR_DATE, touch the -o archive, rather than expecting only one (Closed)

Created:
5 years, 10 months ago by scottmg
Modified:
5 years, 10 months ago
CC:
gyp-developer_googlegroups.com, M-A Ruel
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

mac: Followup to ZERO_AR_DATE, touch the -o archive, rather than expecting only one After https://codereview.chromium.org/791993005/. When multiarch, libtool is run as "... -o foo.a foo.i386.a foo.x86_64.a" so previously the touch wouldn't happen. Instead, look for the -o, and touch that archive. Add ARCHS to test to exercise this. R=sebmarchand@chromium.org, thakis@chromium.org BUG=451499 Committed: https://code.google.com/p/gyp/source/detail?r=2029

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M pylib/gyp/mac_tool.py View 1 1 chunk +6 lines, -7 lines 0 comments Download
M test/mac/libtool-zero/test.gyp View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
scottmg
5 years, 10 months ago (2015-01-28 21:39:39 UTC) #3
Sébastien Marchand
LGTM. Thanks for fixing my bugs. I'm not so familiar with OS X etc, so ...
5 years, 10 months ago (2015-01-28 21:43:45 UTC) #4
Nico
lgtm, thanks!
5 years, 10 months ago (2015-01-28 22:29:59 UTC) #5
scottmg
Committed patchset #2 (id:20001) manually as 2029 (presubmit successful).
5 years, 10 months ago (2015-01-29 18:22:17 UTC) #6
scottmg
5 years, 10 months ago (2015-01-29 18:23:13 UTC) #7
Message was sent while issue was closed.
On 2015/01/29 18:22:17, scottmg wrote:
> Committed patchset #2 (id:20001) manually as 2029 (presubmit successful).

Wow! Committing to gyp: definitely Computer Science's hardest problem.

Powered by Google App Engine
This is Rietveld 408576698