Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 879333005: Use weak cell to embed known map in CompareIC (Closed)

Created:
5 years, 10 months ago by ulan
Modified:
5 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use weak cell to embed known map in CompareIC BUG=v8:3663 LOG=N Committed: https://crrev.com/246a749a6f7e7e3a025bb032bc0c643656c9b08f Cr-Commit-Position: refs/heads/master@{#26386}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -10 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ulan
PTAL
5 years, 10 months ago (2015-02-02 14:25:18 UTC) #2
Toon Verwaest
lgtm
5 years, 10 months ago (2015-02-02 17:24:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879333005/1
5 years, 10 months ago (2015-02-02 17:37:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-02 17:57:46 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-02 17:57:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/246a749a6f7e7e3a025bb032bc0c643656c9b08f
Cr-Commit-Position: refs/heads/master@{#26386}

Powered by Google App Engine
This is Rietveld 408576698