Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 879333003: Don't skip displaying zoom levels for host-only zoom changes. (Closed)

Created:
5 years, 10 months ago by Sam McNally
Modified:
5 years, 10 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't skip displaying zoom levels for host-only zoom changes. A previous change to skip displaying zoom levels for host and scheme zoom changes caused host-only zoom changes to be skipped due to surprise case fallthrough. This adds a break so the correct zoom settings are displayed. BUG=454254 Committed: https://crrev.com/e6e20775331b1c2e898fb6c87cd57eeec931434c Cr-Commit-Position: refs/heads/master@{#314275}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/webui/options/content_settings_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Sam McNally
5 years, 10 months ago (2015-02-02 06:22:55 UTC) #2
Dan Beam
lgtm
5 years, 10 months ago (2015-02-02 16:08:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879333003/1
5 years, 10 months ago (2015-02-03 01:39:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (None)
5 years, 10 months ago (2015-02-03 03:41:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879333003/1
5 years, 10 months ago (2015-02-03 03:43:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 05:43:48 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 05:44:37 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6e20775331b1c2e898fb6c87cd57eeec931434c
Cr-Commit-Position: refs/heads/master@{#314275}

Powered by Google App Engine
This is Rietveld 408576698