Support buttons attribute for drag event (blink side).

Support buttons attribute for drag event (blink side).

Support buttons attribute for drag event.

Chromium side patch: https://crrev.com/878413003

BUG=276941
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191686

[zino, 2015-01-28 14:44:10]

jinho.bang@samsung.com changed reviewers:
+ rbyers@chromium.org

[zino, 2015-02-04 09:58:11]

Please take a look.

Thank you.

[Rick Byers, 2015-02-04 11:41:15]

rbyers@chromium.org changed reviewers:
+ dcheng@chromium.org

[Rick Byers, 2015-02-04 11:42:34]

Looks good.  +dcheng since he's the drag and drop expert.

https://codereview.chromium.org/879333002/diff/20001/LayoutTests/fast/events/...
File LayoutTests/fast/events/mouse-event-buttons-attribute.html (right):

https://codereview.chromium.org/879333002/diff/20001/LayoutTests/fast/events/...
LayoutTests/fast/events/mouse-event-buttons-attribute.html:130: eventTarget =
target;
can simplify to 'var eventTarget = testSet[n].eventTarget || target'.

https://codereview.chromium.org/879333002/diff/20001/Source/core/page/EventHa...
File Source/core/page/EventHandler.cpp (right):

https://codereview.chromium.org/879333002/diff/20001/Source/core/page/EventHa...
Source/core/page/EventHandler.cpp:1663: // the event is derived from mouse
event. Please see crbug.com/276941.
you can remove this FIXME now!

https://codereview.chromium.org/879333002/diff/20001/Source/web/WebViewImpl.cpp
File Source/web/WebViewImpl.cpp (right):

https://codereview.chromium.org/879333002/diff/20001/Source/web/WebViewImpl.c...
Source/web/WebViewImpl.cpp:236: static int
webInputEventKeyStateToPlatformEventKeyState(int webInputEventKeyState)
This function is redundant with WebInputEventConversion's 
toPlatformMouseEventModifiers function, can you unify them (eg. expose that
function and delete this one)?

Also "key state" is now a poor name for the field in the DragData since it's
really platform mouse event modifiers.  Can you please rename it if it's not too
much trouble?

[dcheng, 2015-02-05 00:34:57]

I'm blink gardening today and tomorrow. I'll try to make sure I look at it this
patch (and the Chrome patch) by Friday. Sorry for the delay.

[zino, 2015-02-06 07:00:40]

Thank you for review :)

https://codereview.chromium.org/879333002/diff/20001/LayoutTests/fast/events/...
File LayoutTests/fast/events/mouse-event-buttons-attribute.html (right):

https://codereview.chromium.org/879333002/diff/20001/LayoutTests/fast/events/...
LayoutTests/fast/events/mouse-event-buttons-attribute.html:130: eventTarget =
target;
On 2015/02/04 11:42:34, Rick Byers wrote:
> can simplify to 'var eventTarget = testSet[n].eventTarget || target'.

Done.

https://codereview.chromium.org/879333002/diff/20001/Source/core/page/EventHa...
File Source/core/page/EventHandler.cpp (right):

https://codereview.chromium.org/879333002/diff/20001/Source/core/page/EventHa...
Source/core/page/EventHandler.cpp:1663: // the event is derived from mouse
event. Please see crbug.com/276941.
On 2015/02/04 11:42:34, Rick Byers wrote:
> you can remove this FIXME now!

Done.

https://codereview.chromium.org/879333002/diff/20001/Source/web/WebViewImpl.cpp
File Source/web/WebViewImpl.cpp (right):

https://codereview.chromium.org/879333002/diff/20001/Source/web/WebViewImpl.c...
Source/web/WebViewImpl.cpp:236: static int
webInputEventKeyStateToPlatformEventKeyState(int webInputEventKeyState)
On 2015/02/04 11:42:34, Rick Byers wrote:
> This function is redundant with WebInputEventConversion's 
> toPlatformMouseEventModifiers function, can you unify them (eg. expose that
> function and delete this one)?
> 
> Also "key state" is now a poor name for the field in the DragData since it's
> really platform mouse event modifiers.  Can you please rename it if it's not
too
> much trouble?

Done.

[dcheng, 2015-02-06 20:01:02]

lgtm

https://codereview.chromium.org/879333002/diff/40001/LayoutTests/fast/events/...
File LayoutTests/fast/events/mouse-event-buttons-attribute.html (right):

https://codereview.chromium.org/879333002/diff/40001/LayoutTests/fast/events/...
LayoutTests/fast/events/mouse-event-buttons-attribute.html:116:
eventSender.mouseDown(0, modifiers);
I guess there's no helping it, but it's a little weird for the mouse buttons to
be split across the first and second args like this.

[Rick Byers, 2015-02-07 11:09:29]

Thanks Daniel.  LGTM also.

https://codereview.chromium.org/879333002/diff/40001/LayoutTests/fast/events/...
File LayoutTests/fast/events/mouse-event-buttons-attribute.html (right):

https://codereview.chromium.org/879333002/diff/40001/LayoutTests/fast/events/...
LayoutTests/fast/events/mouse-event-buttons-attribute.html:116:
eventSender.mouseDown(0, modifiers);
On 2015/02/06 20:01:02, dcheng wrote:
> I guess there's no helping it, but it's a little weird for the mouse buttons
to
> be split across the first and second args like this.

Yeah, it's a little weird for mousedown but it does make some sense.  The second
arg is the state of all modifiers including all buttons.  The first arg is what
button was just depressed.  Think of it like a keydown event for the shift key -
of course it contains all modifiers state, and the particular event also happens
to change one of the modifiers.

[zino, 2015-03-11 09:28:15]

The CQ bit was checked by jinho.bang@samsung.com

[zino, 2015-03-11 09:28:16]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org,
rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/879333002/#ps60001 (title:
"rebase")

[commit-bot: I haz the power, 2015-03-11 09:28:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/879333002/60001

[commit-bot: I haz the power, 2015-03-11 09:39:53]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191686