Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 879303004: Non-SFI mode: Use dummy PID for NaCl's IPC channel for nacl_helper_nonsfi. (Closed)

Created:
5 years, 10 months ago by hidehiko
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, hamaji, mazda, Junichi Uekawa
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Non-SFI mode: Use dummy PID for NaCl's IPC channel for nacl_helper_nonsfi. In nacl_helper_nonsfi, getpid() is prohibited to be called by seccomp-bpf (will be implemented somehow soon). So, base::GetCurrentProcID() used in IPC library, which uses getpid(), would cause a SIGSYS crashing. As, in nacl_helper_nonsfi, PID is actually not used, so this CL replaces it with -1 (dummy PID). Note that the more generic CL crrev.com/695353005, which replaces PID with dummy also on Linux platforms, was landed once, but reverted due to it was still in use (crbug.com/441312). This CL extracts only Non-SFI related part to avoid breakage. TEST=Ran bots. BUG=358465, 441312 CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm Committed: https://crrev.com/763f8be26fd888e0ae7070a1a977238d2d65433b Cr-Commit-Position: refs/heads/master@{#314283}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M ipc/ipc_channel.cc View 1 chunk +6 lines, -1 line 0 comments Download
M ipc/ipc_channel_posix.cc View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
hidehiko
This CL is extracted only Non-SFI parts from https://codereview.chromium.org/695353005/, which was reverted (i.e. I dropped ...
5 years, 10 months ago (2015-02-02 12:33:50 UTC) #2
Mark Seaborn
LGTM
5 years, 10 months ago (2015-02-02 20:59:18 UTC) #3
dmichael (off chromium)
lgtm https://codereview.chromium.org/879303004/diff/1/ipc/ipc_channel_posix.cc File ipc/ipc_channel_posix.cc (right): https://codereview.chromium.org/879303004/diff/1/ipc/ipc_channel_posix.cc#newcode778 ipc/ipc_channel_posix.cc:778: // allowed and would cause a SIGSYS crashing ...
5 years, 10 months ago (2015-02-02 23:43:38 UTC) #4
mdempsky
lgtm
5 years, 10 months ago (2015-02-03 03:32:09 UTC) #5
hidehiko
Thank you for quick review! Submitting. https://codereview.chromium.org/879303004/diff/1/ipc/ipc_channel_posix.cc File ipc/ipc_channel_posix.cc (right): https://codereview.chromium.org/879303004/diff/1/ipc/ipc_channel_posix.cc#newcode778 ipc/ipc_channel_posix.cc:778: // allowed and ...
5 years, 10 months ago (2015-02-03 04:53:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879303004/20001
5 years, 10 months ago (2015-02-03 04:55:00 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-03 07:25:03 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 07:25:48 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/763f8be26fd888e0ae7070a1a977238d2d65433b
Cr-Commit-Position: refs/heads/master@{#314283}

Powered by Google App Engine
This is Rietveld 408576698