Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 879273006: Revert of Fix a crash that MediaPlayerAndroid weak_ptr is incorrectly used across thread (Closed)

Created:
5 years, 10 months ago by qinmin
Modified:
5 years, 10 months ago
Reviewers:
xhwang
CC:
chromium-reviews, posciak+watch_chromium.org, wjia+watch_chromium.org, avayvod+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix a crash that MediaPlayerAndroid weak_ptr is incorrectly used across thread (patchset #1 id:1 of https://codereview.chromium.org/899473002/) Reason for revert: this CL doesn't fix the original issue Original issue's description: > Fix a crash that MediaPlayerAndroid weak_ptr is incorrectly used across thread > > For MediaPlayerListener, the callbacks can happen on a non-UI thread. > Weak_ptr is not thread safe, so we shouldn't bind the weak_ptr in those callbacks. > This change creates a threadsafe proxy class to bridge all the callbacks. > > BUG=453581, 447368, 447367 > > Committed: https://crrev.com/2e9885788692f69203a98fb42347428ef553d640 > Cr-Commit-Position: refs/heads/master@{#314241} TBR=xhwang@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=453581, 447368, 447367 Committed: https://crrev.com/aba6a96e10ca6593a7f97caf9f8f8bcf2894e0ee Cr-Commit-Position: refs/heads/master@{#315352}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -141 lines) Patch
M media/base/android/media_player_android.h View 3 chunks +12 lines, -10 lines 0 comments Download
M media/base/android/media_player_listener.h View 3 chunks +6 lines, -29 lines 0 comments Download
M media/base/android/media_player_listener.cc View 3 chunks +17 lines, -102 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
qinmin
Created Revert of Fix a crash that MediaPlayerAndroid weak_ptr is incorrectly used across thread
5 years, 10 months ago (2015-02-09 18:47:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879273006/1
5 years, 10 months ago (2015-02-09 18:47:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-09 18:49:07 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 18:50:54 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aba6a96e10ca6593a7f97caf9f8f8bcf2894e0ee
Cr-Commit-Position: refs/heads/master@{#315352}

Powered by Google App Engine
This is Rietveld 408576698