Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Side by Side Diff: src/full-codegen.cc

Issue 879273004: Verify that code stubs and full code do not have pointers that can retain (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add comment Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/code-stubs.cc ('k') | src/ic/handler-compiler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/ast.h" 7 #include "src/ast.h"
8 #include "src/ast-numbering.h" 8 #include "src/ast-numbering.h"
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 333 matching lines...) Expand 10 before | Expand all | Expand 10 after
344 code->set_allow_osr_at_loop_nesting_level(0); 344 code->set_allow_osr_at_loop_nesting_level(0);
345 code->set_profiler_ticks(0); 345 code->set_profiler_ticks(0);
346 code->set_back_edge_table_offset(table_offset); 346 code->set_back_edge_table_offset(table_offset);
347 CodeGenerator::PrintCode(code, info); 347 CodeGenerator::PrintCode(code, info);
348 info->SetCode(code); 348 info->SetCode(code);
349 void* line_info = masm.positions_recorder()->DetachJITHandlerData(); 349 void* line_info = masm.positions_recorder()->DetachJITHandlerData();
350 LOG_CODE_EVENT(isolate, CodeEndLinePosInfoRecordEvent(*code, line_info)); 350 LOG_CODE_EVENT(isolate, CodeEndLinePosInfoRecordEvent(*code, line_info));
351 351
352 #ifdef DEBUG 352 #ifdef DEBUG
353 // Check that no context-specific object has been embedded. 353 // Check that no context-specific object has been embedded.
354 code->VerifyEmbeddedObjectsInFullCode(); 354 code->VerifyEmbeddedObjects(Code::kNoContextSpecificPointers);
355 #endif // DEBUG 355 #endif // DEBUG
356 return true; 356 return true;
357 } 357 }
358 358
359 359
360 unsigned FullCodeGenerator::EmitBackEdgeTable() { 360 unsigned FullCodeGenerator::EmitBackEdgeTable() {
361 // The back edge table consists of a length (in number of entries) 361 // The back edge table consists of a length (in number of entries)
362 // field, and then a sequence of entries. Each entry is a pair of AST id 362 // field, and then a sequence of entries. Each entry is a pair of AST id
363 // and code-relative pc offset. 363 // and code-relative pc offset.
364 masm()->Align(kPointerSize); 364 masm()->Align(kPointerSize);
(...skipping 1463 matching lines...) Expand 10 before | Expand all | Expand 10 after
1828 } 1828 }
1829 codegen_->PrepareForBailoutForId(exit_id_, NO_REGISTERS); 1829 codegen_->PrepareForBailoutForId(exit_id_, NO_REGISTERS);
1830 codegen_->scope_ = saved_scope_; 1830 codegen_->scope_ = saved_scope_;
1831 } 1831 }
1832 1832
1833 1833
1834 #undef __ 1834 #undef __
1835 1835
1836 1836
1837 } } // namespace v8::internal 1837 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/code-stubs.cc ('k') | src/ic/handler-compiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698