Generalize upload_network_service.py to support uploading other services.

Generalize upload_network_service.py to support uploading other services.

This CL generalizes upload_network_service.py to support uploading other
services (currently, html_viewer). html_viewer.mojo is not zipped before being
uploaded so that it can be accessed dynamically by mojo_shell.

Committed: https://crrev.com/6c5c867d87fc9a053b1bb440518647d6741e6294
Cr-Commit-Position: refs/heads/master@{#314533}

[blundell, 2015-02-03 15:44:56]

blundell@chromium.org changed reviewers:
+ jamesr@chromium.org, ppi@chromium.org

[blundell, 2015-02-03 15:46:23]

Just remembered that html_viewer.mojo has the issue where it assumes that a
given .so is present, which needs to be sorted out. Still, no harm in this
change being made now.

[ppi, 2015-02-03 16:08:10]

https://codereview.chromium.org/879233006/diff/40001/mojo/services/upload_ser...
File mojo/services/upload_service.py (right):

https://codereview.chromium.org/879233006/diff/40001/mojo/services/upload_ser...
mojo/services/upload_service.py:16: # containing this file.
nit: note that it also defines the gs path that the binary will be uploaded to.

https://codereview.chromium.org/879233006/diff/40001/mojo/services/upload_ser...
mojo/services/upload_service.py:115: parser.add_argument("service",
The mandatory argument should go first I think.

[ppi, 2015-02-03 16:18:20]

lgtm

https://codereview.chromium.org/879233006/diff/40001/mojo/services/upload_ser...
File mojo/services/upload_service.py (right):

https://codereview.chromium.org/879233006/diff/40001/mojo/services/upload_ser...
mojo/services/upload_service.py:115: parser.add_argument("service",
On 2015/02/03 16:08:09, ppi wrote:
> The mandatory argument should go first I think.

As discussed live, turn's out it shouldn't, please disregard. Thanks.

[blundell, 2015-02-03 16:19:41]

https://codereview.chromium.org/879233006/diff/40001/mojo/services/upload_ser...
File mojo/services/upload_service.py (right):

https://codereview.chromium.org/879233006/diff/40001/mojo/services/upload_ser...
mojo/services/upload_service.py:16: # containing this file.
On 2015/02/03 16:08:09, ppi wrote:
> nit: note that it also defines the gs path that the binary will be uploaded
to.

I actually would prefer not to do this unless you feel strongly as I fear that
the comment could easily grow out-of-date if we decide to change the format of
the bucketing.

[ppi, 2015-02-03 16:35:45]

still lgtm, thanks

[jamesr, 2015-02-03 18:29:57]

lgtm

https://codereview.chromium.org/879233006/diff/40001/mojo/services/upload_ser...
File mojo/services/upload_service.py (right):

https://codereview.chromium.org/879233006/diff/40001/mojo/services/upload_ser...
mojo/services/upload_service.py:123: sys.exit(1)
return 1, don't sys.exit().

[blundell, 2015-02-04 10:04:18]

https://codereview.chromium.org/879233006/diff/40001/mojo/services/upload_ser...
File mojo/services/upload_service.py (right):

https://codereview.chromium.org/879233006/diff/40001/mojo/services/upload_ser...
mojo/services/upload_service.py:123: sys.exit(1)
On 2015/02/03 18:29:57, jamesr wrote:
> return 1, don't sys.exit().

Done.

[blundell, 2015-02-04 10:04:27]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2015-02-04 10:04:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/879233006/60001

[commit-bot: I haz the power, 2015-02-04 10:40:08]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-02-04 10:40:59]

Patchset 4 (id:??) landed as
https://crrev.com/6c5c867d87fc9a053b1bb440518647d6741e6294
Cr-Commit-Position: refs/heads/master@{#314533}