Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: components/policy/core/common/remote_commands/testing_remote_commands_server.h

Issue 879233003: Initial RemoteCommandService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remote-commands
Patch Set: rebase, fixes addressing #31 Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/common/remote_commands/testing_remote_commands_server.h
diff --git a/components/policy/core/common/remote_commands/testing_remote_commands_server.h b/components/policy/core/common/remote_commands/testing_remote_commands_server.h
new file mode 100644
index 0000000000000000000000000000000000000000..74ec0e3d1749bc87ecec2bb33e0260713469ba64
--- /dev/null
+++ b/components/policy/core/common/remote_commands/testing_remote_commands_server.h
@@ -0,0 +1,126 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_POLICY_CORE_COMMON_REMOTE_COMMANDS_TESTING_REMOTE_COMMANDS_SERVER_H_
+#define COMPONENTS_POLICY_CORE_COMMON_REMOTE_COMMANDS_TESTING_REMOTE_COMMANDS_SERVER_H_
+
+#include <stddef.h>
+#include <string>
+#include <vector>
+
+#include "base/callback_forward.h"
+#include "base/macros.h"
+#include "base/memory/ref_counted.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/memory/weak_ptr.h"
+#include "base/synchronization/lock.h"
+#include "base/threading/thread_checker.h"
+#include "components/policy/core/common/remote_commands/remote_command_job.h"
+#include "policy/proto/device_management_backend.pb.h"
+
+namespace base {
+class Clock;
+class SingleThreadTaskRunner;
+} // namespace base
+
+namespace policy {
+
+// This class implements server-side logic for remote commands service tests. It
+// acts just like a queue, and there are mainly two exposed methods for this
+// purpose. Test authors are expected to call IssueCommand() to add commands to
+// the queue in their tests. FetchCommands() should be called when serving a
+// request to the server intercepted e.g. via a net::URLRequestInterceptor or a
+// mock CloudPolicyClient.
+// In addition, this class also supports verifying command result sent back to
+// server, and test authors should provide a callback for this purpose when
+// issuing a command.
+// All methods except FetchCommands() should be called from the same thread, and
+// FetchCommands() can be called from any thread.
+// Note that test author is responsible for ensuring that FetchCommands() is not
+// called from another thread after |this| has been destroyed.
+class TestingRemoteCommandsServer {
+ public:
+ TestingRemoteCommandsServer();
+ virtual ~TestingRemoteCommandsServer();
+
+ using RemoteCommands = std::vector<enterprise_management::RemoteCommand>;
+ using RemoteCommandResults =
+ std::vector<enterprise_management::RemoteCommandResult>;
+
+ // Callback called when a command's result is reported back to the server.
+ using ResultReportedCallback =
+ base::Callback<void(const enterprise_management::RemoteCommandResult&)>;
+
+ // Create and add a command with |type| as command type and |payload| as
+ // command payload if it's not empty. |clock_| will be used to get the
+ // command issue time. |reported_callback| will be called from the same
+ // thread when a command result is reported back to the server.
+ // If |skip_next_fetch| is true, the command will only actually be added to
+ // the queue after the next fetch completes.
+ // Commands with |reported_callback| set are required to be reported back to
+ // the server and |reported_callback| itself will be called at that time.
+ void IssueCommand(enterprise_management::RemoteCommand_Type type,
+ const std::string& payload,
+ const ResultReportedCallback& reported_callback,
+ bool skip_next_fetch);
+
+ // Fetch commands, acknowledging all commands up to and including
+ // |last_command_id|, and provide |previous_job_results| as results for
+ // previous commands. |last_command_id| can be a nullptr which indicates that
+ // no commands will be acknowledged.
+ // See the protobuf definition for a definition of the protocol between server
+ // and client for remote command fetching.
+ // Unlike every other methods in the class, this method can be called from
+ // any thread.
+ RemoteCommands FetchCommands(
+ scoped_ptr<RemoteCommandJob::UniqueIDType> last_command_id,
+ const RemoteCommandResults& previous_job_results);
+
+ // Set alternative clock for obtaining the command issue time. The default
+ // clock uses the system clock.
+ void SetClock(scoped_ptr<base::Clock> clock);
+
+ // Get the number of commands for which no results have been reported yet.
+ // This number also includes commands which have not been fetched yet.
+ size_t NumberOfCommandsPendingResult() const;
+
+ private:
+ struct RemoteCommandWithCallback;
+
+ void ReportJobResult(
+ const ResultReportedCallback& reported_callback,
+ const enterprise_management::RemoteCommandResult& job_result) const;
+
+ // The main command queue.
+ std::vector<RemoteCommandWithCallback> commands_;
+
+ // Commands which will be added to the main queue after the next fetch.
+ std::vector<RemoteCommandWithCallback> commands_issued_after_next_fetch_;
+
+ // The latest command ID generated by server. This test server generates
+ // strictly monotonically increasing unique IDs.
+ RemoteCommandJob::UniqueIDType last_generated_unique_id_ = 0;
+
+ // Clock used to generate command issue time when IssueCommand() is called.
+ scoped_ptr<base::Clock> clock_;
+
+ // A lock protecting the command queues, as well as generated and acknowledged
+ // IDs.
+ base::Lock lock_;
+
+ // The thread on which this test server is created, usually the UI thread.
+ scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
+
+ // A weak pointer created early so that it can be accessed from other threads.
+ base::WeakPtr<TestingRemoteCommandsServer> weak_ptr_to_this_;
+
+ base::ThreadChecker thread_checker_;
+ base::WeakPtrFactory<TestingRemoteCommandsServer> weak_factory_;
+
+ DISALLOW_COPY_AND_ASSIGN(TestingRemoteCommandsServer);
+};
+
+} // namespace policy
+
+#endif // COMPONENTS_POLICY_CORE_COMMON_REMOTE_COMMANDS_TESTING_REMOTE_COMMANDS_SERVER_H_

Powered by Google App Engine
This is Rietveld 408576698