components/policy/core/common/remote_commands/remote_commands_queue.cc - Issue 879233003: Initial RemoteCommandService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/remote_commands/remote_commands_queue.cc

Issue 879233003: Initial RemoteCommandService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remote-commands

Patch Set: addressed #25 Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/policy/core/common/cloud/mock_cloud_policy_client.h ('K') | « components/policy/core/common/remote_commands/remote_commands_queue.h ('k') | components/policy/core/common/remote_commands/remote_commands_service.h » ('j') | components/policy/core/common/remote_commands/remote_commands_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/remote_commands/remote_commands_queue.cc

diff --git a/components/policy/core/common/remote_commands/remote_commands_queue.cc b/components/policy/core/common/remote_commands/remote_commands_queue.cc

index 6234c9261843e766889a9e0e57f8572dfe93a26f..8c0f2b76edb7e778275029a1ff3a62bd9ee631e3 100644

--- a/components/policy/core/common/remote_commands/remote_commands_queue.cc

+++ b/components/policy/core/common/remote_commands/remote_commands_queue.cc

@@ -20,7 +20,8 @@ RemoteCommandsQueue::RemoteCommandsQueue() : clock_(new base::DefaultClock()) {

RemoteCommandsQueue::~RemoteCommandsQueue() {

while (!incoming_commands_.empty())

incoming_commands_.pop();

- running_command_.reset();

+ if (running_command_)

+ running_command_->Terminate();

}

void RemoteCommandsQueue::AddObserver(Observer* observer) {