Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Unified Diff: components/policy/core/common/remote_commands/remote_commands_service.cc

Issue 879233003: Initial RemoteCommandService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remote-commands
Patch Set: fixes addressing #10 #11 and #12 Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/common/remote_commands/remote_commands_service.cc
diff --git a/components/policy/core/common/remote_commands/remote_commands_service.cc b/components/policy/core/common/remote_commands/remote_commands_service.cc
new file mode 100644
index 0000000000000000000000000000000000000000..1075e5630fb9d66ffd67f42fbd1afcf1203be602
--- /dev/null
+++ b/components/policy/core/common/remote_commands/remote_commands_service.cc
@@ -0,0 +1,124 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/policy/core/common/remote_commands/remote_commands_service.h"
+
+#include <algorithm>
+#include <string>
+
+#include "base/bind.h"
+#include "base/bind_helpers.h"
+#include "base/logging.h"
+#include "base/time/time.h"
+#include "components/policy/core/common/cloud/cloud_policy_client.h"
+#include "components/policy/core/common/remote_commands/remote_commands_factory.h"
+
+namespace policy {
+
+namespace em = enterprise_management;
+
+RemoteCommandsService::RemoteCommandsService(
+ scoped_ptr<RemoteCommandsFactory> factory,
+ CloudPolicyClient* client)
+ : factory_(factory.Pass()), client_(client), weak_factory_(this) {
+ queue_.AddObserver(this);
+}
+
+RemoteCommandsService::~RemoteCommandsService() {
+ queue_.RemoveObserver(this);
+}
+
+bool RemoteCommandsService::FetchRemoteCommands() {
+ if (command_fetch_in_progress_) {
+ has_enqueued_fetch_request_ = true;
+ return false;
+ }
+
+ command_fetch_in_progress_ = true;
+
+ std::vector<em::RemoteCommandResult> previous_results;
+ unsent_results_.swap(previous_results);
+
+ client_->FetchRemoteCommands(
+ last_executed_command_id_, previous_results,
+ base::Bind(&RemoteCommandsService::OnRemoteCommandsFetched,
+ weak_factory_.GetWeakPtr()));
+ return true;
+}
+
+void RemoteCommandsService::AddCommand(
+ const enterprise_management::RemoteCommand& command) {
+ if (!command.has_type() || !command.has_unique_id()) {
+ LOG(WARNING) << "Invalid remote command from server.";
+ return;
+ }
+
+ // If the command is already fetched, ignore it instead.
+ if (!fetched_command_ids_.insert(command.unique_id()).second)
+ return;
+
+ scoped_ptr<RemoteCommandJob> job = factory_->BuildJobForType(command.type());
+
+ if (!job || !job->Init(command)) {
+ em::RemoteCommandResult ignored_result;
+ ignored_result.set_result(
+ em::RemoteCommandResult_ResultType_RESULT_IGNORED);
+ ignored_result.set_unique_id(command.unique_id());
+ unsent_results_.push_back(ignored_result);
+ return;
+ }
+
+ queue_.AddJob(job.Pass());
+}
+
+void RemoteCommandsService::OnJobStarted(RemoteCommandJob* command) {
+ last_executed_command_id_ = command->unique_id();
+ // TODO(binjin): Evaluate the security risks and attempts to sync
+ // |last_executed_command_id_| to some persistent source, so that we can
+ // reload it later without relying solely on server to keep our last
+ // acknowledged command id.
+}
+
+void RemoteCommandsService::OnJobFinished(RemoteCommandJob* command) {
+ em::RemoteCommandResult result;
+ result.set_unique_id(command->unique_id());
+ result.set_timestamp((command->execution_started_time() -
+ base::Time::UnixEpoch()).InMilliseconds());
+
+ if (command->status() == RemoteCommandJob::SUCCEEDED) {
+ result.set_result(em::RemoteCommandResult_ResultType_RESULT_SUCCESS);
+ scoped_ptr<std::string> result_payload = command->GetResultPayload();
+ if (result_payload)
+ result.set_payload(*result_payload);
+ } else if (command->status() == RemoteCommandJob::EXPIRED ||
+ command->status() == RemoteCommandJob::INVALID) {
+ result.set_result(em::RemoteCommandResult_ResultType_RESULT_IGNORED);
+ } else {
+ result.set_result(em::RemoteCommandResult_ResultType_RESULT_FAILURE);
+ }
+
+ unsent_results_.push_back(result);
+
+ FetchRemoteCommands();
+}
+
+void RemoteCommandsService::OnRemoteCommandsFetched(
+ const std::vector<enterprise_management::RemoteCommand>& commands) {
+ DCHECK(command_fetch_in_progress_);
+ command_fetch_in_progress_ = false;
+
+ for (const auto& command : commands)
+ AddCommand(command);
+
+ // Start another fetch request job immediately if there is there are unsent
+ // command results or enqueued fetch requests.
+ if (!unsent_results_.empty() || has_enqueued_fetch_request_) {
+ has_enqueued_fetch_request_ = false;
+ FetchRemoteCommands();
+ } else {
+ has_enqueued_fetch_request_ = false;
+ }
+}
+
+} // namespace policy

Powered by Google App Engine
This is Rietveld 408576698