 Chromium Code Reviews
 Chromium Code Reviews Issue 879233003:
  Initial RemoteCommandService  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@remote-commands
    
  
    Issue 879233003:
  Initial RemoteCommandService  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@remote-commands| Index: components/policy/core/common/remote_commands/remote_command_job.h | 
| diff --git a/components/policy/core/common/remote_commands/remote_command_job.h b/components/policy/core/common/remote_commands/remote_command_job.h | 
| index dd23747ead94c29fdde8d9af732532c2669998d1..f03466af97e425b544854b53bd069c7602f70c4a 100644 | 
| --- a/components/policy/core/common/remote_commands/remote_command_job.h | 
| +++ b/components/policy/core/common/remote_commands/remote_command_job.h | 
| @@ -37,6 +37,16 @@ class POLICY_EXPORT RemoteCommandJob { | 
| TERMINATED, // The job was terminated before finishing by itself. | 
| }; | 
| + // XXX | 
| + class Factory { | 
| 
bartfab (slow)
2015/02/12 14:29:20
This should be a separate class, in its own header
 
binjin
2015/02/16 22:46:23
Done.
 | 
| + public: | 
| + virtual ~Factory() {} | 
| 
bartfab (slow)
2015/02/12 14:29:19
Nit: Never inline virtual methods.
 
binjin
2015/02/16 22:46:24
Done.
 | 
| + | 
| + // XXX | 
| + virtual scoped_ptr<RemoteCommandJob> BuildJobForType( | 
| + enterprise_management::RemoteCommand_Type type) = 0; | 
| + }; | 
| + | 
| using FinishedCallback = base::Closure; | 
| virtual ~RemoteCommandJob(); |