Initial RemoteCommandService

components/policy/core/common/cloud/cloud_policy_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_POLICY_CORE_COMMON_CLOUD_CLOUD_POLICY_CLIENT_H_
 #define COMPONENTS_POLICY_CORE_COMMON_CLOUD_CLOUD_POLICY_CLIENT_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 128 matching lines @@
   // Sends an unregistration request to the server.
   virtual void Unregister();
 
   // Upload a device certificate to the server.  Like FetchPolicy, this method
   // requires that the client is in a registered state.  |certificate_data| must
   // hold the X.509 certificate data to be sent to the server.  The |callback|
   // will be called when the operation completes.
   virtual void UploadCertificate(const std::string& certificate_data,
                                  const StatusCallback& callback);
 
+  // XXX
+  virtual scoped_ptr<DeviceManagementRequestJob> CreateRemoteCommandsJob();

[bartfab (slow), 2015/01/29 10:18:05]

Why not have this method create a job and send it to the outbound queue in one
go?

[binjin, 2015/01/29 10:44:10]

That will introduce some logic about how to construct the remote command request
header into policy specified code, which is what I try to avoid.

[bartfab (slow), 2015/01/29 15:28:58]

If you look at Drew's solution, this is exactly what he does:

https://codereview.chromium.org/845313008/diff/160001/components/policy/core/...

He passes two protos that the CloudPolicyClient stuffs into the command before
sending it off. I think it is a good idea to be consistent with that approach
for remote commands as well. The logic that actually builds these protos does
not belong into the client. The client simply copies them over and sends the
result.

+
   // Adds an observer to be called back upon policy and state changes.
   void AddObserver(Observer* observer);
 
   // Removes the specified observer.
   void RemoveObserver(Observer* observer);
 
   // Sets the status provider for this client, or NULL if no provider.
   // ClouldPolicyClient takes ownership of the passed |provider|.
   void SetStatusProvider(scoped_ptr<StatusProvider> provider);
 
@@ skipping 155 matching lines @@
   ObserverList<Observer, true> observers_;
   scoped_refptr<net::URLRequestContextGetter> request_context_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(CloudPolicyClient);
 };
 
 }  // namespace policy
 
 #endif  // COMPONENTS_POLICY_CORE_COMMON_CLOUD_CLOUD_POLICY_CLIENT_H_