Initial RemoteCommandService

chrome/browser/policy/cloud/test_request_interceptor.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/policy/cloud/test_request_interceptor.h"
 
 #include <limits>
 #include <queue>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop_proxy.h"
 #include "base/run_loop.h"
 #include "base/sequenced_task_runner.h"
+#include "components/policy/core/common/remote_commands/testing_remote_commands_server.h"
 #include "content/public/browser/browser_thread.h"
 #include "net/base/net_errors.h"
 #include "net/base/upload_bytes_element_reader.h"
 #include "net/base/upload_data_stream.h"
 #include "net/base/upload_element_reader.h"
 #include "net/test/url_request/url_request_mock_http_job.h"
 #include "net/url_request/url_request_error_job.h"
 #include "net/url_request/url_request_filter.h"
 #include "net/url_request/url_request_interceptor.h"
 #include "net/url_request/url_request_test_job.h"
 #include "url/gurl.h"
 
 namespace em = enterprise_management;
 
 namespace policy {
 
 namespace {
 
+static const char kGoodHeaders[] =
+    "HTTP/1.1 200 OK\0"
+    "Content-type: application/protobuf\0"
+    "\0";
+static const char kBadHeaders[] =
+    "HTTP/1.1 400 Bad request\0"
+    "Content-type: application/protobuf\0"
+    "\0";
+
 // Helper callback for jobs that should fail with a network |error|.
 net::URLRequestJob* ErrorJobCallback(int error,
                                      net::URLRequest* request,
                                      net::NetworkDelegate* network_delegate) {
   return new net::URLRequestErrorJob(request, network_delegate, error);
 }
 
 // Helper callback for jobs that should fail with a 400 HTTP error.
 net::URLRequestJob* BadRequestJobCallback(
     net::URLRequest* request,
     net::NetworkDelegate* network_delegate) {
-  static const char kBadHeaders[] =
-      "HTTP/1.1 400 Bad request\0"
-      "Content-type: application/protobuf\0"
-      "\0";
-  std::string headers(kBadHeaders, arraysize(kBadHeaders));
+  const std::string headers(kBadHeaders, arraysize(kBadHeaders));
   return new net::URLRequestTestJob(
       request, network_delegate, headers, std::string(), true);
 }
 
 net::URLRequestJob* FileJobCallback(const base::FilePath& file_path,
                                     net::URLRequest* request,
                                     net::NetworkDelegate* network_delegate) {
   return new net::URLRequestMockHTTPJob(
       request,
       network_delegate,
       file_path,
       content::BrowserThread::GetBlockingPool()
           ->GetTaskRunnerWithShutdownBehavior(
               base::SequencedWorkerPool::SKIP_ON_SHUTDOWN));
 }
 
 // Parses the upload data in |request| into |request_msg|, and validates the
 // request. The query string in the URL must contain the |expected_type| for
 // the "request" parameter. Returns true if all checks succeeded, and the
-// request data has been parsed into |request_msg|.
+// request data has been parsed into |request_msg| if it's not null.
 bool ValidRequest(net::URLRequest* request,
                   const std::string& expected_type,
                   em::DeviceManagementRequest* request_msg) {
   if (request->method() != "POST")
     return false;
   std::string spec = request->url().spec();
   if (spec.find("request=" + expected_type) == std::string::npos)
     return false;
 
   // This assumes that the payload data was set from a single string. In that
   // case the UploadDataStream has a single UploadBytesElementReader with the
   // data in memory.
   const net::UploadDataStream* stream = request->get_upload();
   if (!stream)
     return false;
   const ScopedVector<net::UploadElementReader>* readers =
       stream->GetElementReaders();
   if (!readers || readers->size() != 1u)
     return false;
   const net::UploadBytesElementReader* reader = (*readers)[0]->AsBytesReader();
   if (!reader)
     return false;
   std::string data(reader->bytes(), reader->length());
-  if (!request_msg->ParseFromString(data))
+  if (request_msg && !request_msg->ParseFromString(data))
     return false;
 
   return true;
 }
 
 // Helper callback for register jobs that should suceed. Validates the request
 // parameters and returns an appropriate response job. If |expect_reregister|
 // is true then the reregister flag must be set in the DeviceRegisterRequest
 // protobuf.
 net::URLRequestJob* RegisterJobCallback(
     em::DeviceRegisterRequest::Type expected_type,
     bool expect_reregister,
     net::URLRequest* request,
     net::NetworkDelegate* network_delegate) {
   em::DeviceManagementRequest request_msg;
   if (!ValidRequest(request, "register", &request_msg))
     return BadRequestJobCallback(request, network_delegate);
 
   if (!request_msg.has_register_request() ||
       request_msg.has_unregister_request() ||
       request_msg.has_policy_request() ||
       request_msg.has_device_status_report_request() ||
       request_msg.has_session_status_report_request() ||
-      request_msg.has_auto_enrollment_request()) {
+      request_msg.has_auto_enrollment_request() ||
+      request_msg.has_remote_command_request()) {
     return BadRequestJobCallback(request, network_delegate);
   }
 
   const em::DeviceRegisterRequest& register_request =
       request_msg.register_request();
   if (expect_reregister &&
       (!register_request.has_reregister() || !register_request.reregister())) {
     return BadRequestJobCallback(request, network_delegate);
   } else if (!expect_reregister &&
              register_request.has_reregister() &&
              register_request.reregister()) {
     return BadRequestJobCallback(request, network_delegate);
   }
 
   if (!register_request.has_type() || register_request.type() != expected_type)
     return BadRequestJobCallback(request, network_delegate);
 
   em::DeviceManagementResponse response;
   em::DeviceRegisterResponse* register_response =
       response.mutable_register_response();
   register_response->set_device_management_token("s3cr3t70k3n");
   std::string data;
   response.SerializeToString(&data);
 
-  static const char kGoodHeaders[] =
-      "HTTP/1.1 200 OK\0"
-      "Content-type: application/protobuf\0"
-      "\0";
-  std::string headers(kGoodHeaders, arraysize(kGoodHeaders));
+  const std::string headers(kGoodHeaders, arraysize(kGoodHeaders));
+  return new net::URLRequestTestJob(request, network_delegate, headers, data,
+                                    true);
+}
+
+net::URLRequestJob* FetchRemoteCommandsJobCallback(
+    TestingRemoteCommandsServer* server,
+    size_t expected_command_results,
+    size_t expected_fetched_commands,
+    net::URLRequest* request,
+    net::NetworkDelegate* network_delegate) {
+  em::DeviceManagementRequest request_msg;
+  if (!ValidRequest(request, "remote_commands", &request_msg)) {

[bartfab (slow), 2015/02/17 18:13:52]

Nit: No need for {}.

[binjin, 2015/02/18 15:37:48]

Done.

+    return BadRequestJobCallback(request, network_delegate);
+  }
+
+  if (!request_msg.has_remote_command_request())
+    return BadRequestJobCallback(request, network_delegate);
+
+  const em::DeviceRemoteCommandRequest& remote_command_request =
+      request_msg.remote_command_request();
+  if (!remote_command_request.has_last_command_unique_id())
+    return BadRequestJobCallback(request, network_delegate);
+
+  std::vector<em::RemoteCommandResult> previous_results(
+      remote_command_request.command_results().begin(),
+      remote_command_request.command_results().end());
+
+  // Verify the number of results for previous commands.
+  DCHECK_EQ(expected_command_results, previous_results.size());
+
+  // Interact with TestingRemoteCommandsServer to actually fetch commands,
+  // and verify the number of fetched commands.
+  std::vector<em::RemoteCommand> fetched_commands = server->FetchCommandsFromIO(

[bartfab (slow), 2015/02/17 18:13:52]

Nit: const.

[binjin, 2015/02/18 15:37:48]

Done.

+      remote_command_request.last_command_unique_id(), previous_results);
+  DCHECK_EQ(expected_fetched_commands, fetched_commands.size());
+
+  // Generating response.
+  em::DeviceManagementResponse response;
+  em::DeviceRemoteCommandResponse* remote_command_response =
+      response.mutable_remote_command_response();
+
+  for (const auto& fetched_command : fetched_commands)
+    *remote_command_response->add_commands() = fetched_command;
+  std::string data;
+  response.SerializeToString(&data);
+
+  const std::string headers(kGoodHeaders, arraysize(kGoodHeaders));
   return new net::URLRequestTestJob(
       request, network_delegate, headers, data, true);
 }
 
 void RegisterHttpInterceptor(
     const std::string& hostname,
     scoped_ptr<net::URLRequestInterceptor> interceptor) {
   net::URLRequestFilter::GetInstance()->AddHostnameInterceptor(
       "http", hostname, interceptor.Pass());
 }
 
 }  // namespace
 
 class TestRequestInterceptor::Delegate : public net::URLRequestInterceptor {
  public:
   Delegate(const std::string& hostname,
            scoped_refptr<base::SequencedTaskRunner> io_task_runner);
   ~Delegate() override;
 
   // net::URLRequestInterceptor implementation:
   net::URLRequestJob* MaybeInterceptRequest(
       net::URLRequest* request,
       net::NetworkDelegate* network_delegate) const override;
 
   void GetPendingSize(size_t* pending_size) const;
   void AddRequestServicedCallback(const base::Closure& callback);
   void PushJobCallback(const JobCallback& callback);
+  void AddIgnoredRequestType(const std::string& ignored_type);
 
  private:
   static void InvokeRequestServicedCallbacks(
       scoped_ptr<std::vector<base::Closure>> callbacks);
 
+  std::vector<std::string> ignored_types;

[bartfab (slow), 2015/02/17 18:13:52]

Nit: Add trailing underscore.

[binjin, 2015/02/18 15:37:48]

Done.

+
   const std::string hostname_;
   scoped_refptr<base::SequencedTaskRunner> io_task_runner_;
 
   // The queue of pending callbacks. 'mutable' because MaybeCreateJob() is a
   // const method; it can't reenter though, because it runs exclusively on
   // the IO thread.
   mutable std::queue<JobCallback> pending_job_callbacks_;
 
   // Queue of pending request serviced callbacks. Mutable for the same reason
   // as |pending_job_callbacks_|.
@@ skipping 16 matching lines @@
     // Reject requests to other servers.
     return ErrorJobCallback(
         net::ERR_CONNECTION_REFUSED, request, network_delegate);
   }
 
   if (pending_job_callbacks_.empty()) {
     // Reject dmserver requests by default.
     return BadRequestJobCallback(request, network_delegate);
   }
 
+  // If the request is explicitly ignored, don't handle this request by
+  // sending back an bad request response.
+  for (const std::string& ignored_type : ignored_types)

[bartfab (slow), 2015/02/17 18:13:52]

Nit: Add curly braces.

[binjin, 2015/02/18 15:37:48]

Done.

+    if (ValidRequest(request, ignored_type, nullptr))
+      return BadRequestJobCallback(request, network_delegate);
+
   // Invoke any callbacks that are waiting for the next request to be serviced
   // after this job is serviced.
   if (!request_serviced_callbacks_.empty()) {
     scoped_ptr<std::vector<base::Closure>> callbacks(
         new std::vector<base::Closure>);
     callbacks->swap(request_serviced_callbacks_);
     io_task_runner_->PostTask(
         FROM_HERE, base::Bind(&Delegate::InvokeRequestServicedCallbacks,
                               base::Passed(&callbacks)));
   }
@@ skipping 14 matching lines @@
   CHECK(io_task_runner_->RunsTasksOnCurrentThread());
   request_serviced_callbacks_.push_back(callback);
 }
 
 void TestRequestInterceptor::Delegate::PushJobCallback(
     const JobCallback& callback) {
   CHECK(io_task_runner_->RunsTasksOnCurrentThread());
   pending_job_callbacks_.push(callback);
 }
 
+void TestRequestInterceptor::Delegate::AddIgnoredRequestType(
+    const std::string& ignored_type) {
+  CHECK(io_task_runner_->RunsTasksOnCurrentThread());
+
+  ignored_types.push_back(ignored_type);
+}
+
 // static
 void TestRequestInterceptor::Delegate::InvokeRequestServicedCallbacks(
     scoped_ptr<std::vector<base::Closure>> callbacks) {
   for (const auto& p : *callbacks)
     p.Run();
 }
 
 TestRequestInterceptor::TestRequestInterceptor(const std::string& hostname,
     scoped_refptr<base::SequencedTaskRunner> io_task_runner)
     : hostname_(hostname),
@@ skipping 34 matching lines @@
                              base::Unretained(delegate_),
                              post_callback));
 }
 
 void TestRequestInterceptor::PushJobCallback(const JobCallback& callback) {
   PostToIOAndWait(base::Bind(&Delegate::PushJobCallback,
                              base::Unretained(delegate_),
                              callback));
 }
 
+void TestRequestInterceptor::AddIgnoredRequestType(
+    const std::string& ignored_type) {
+  PostToIOAndWait(base::Bind(&Delegate::AddIgnoredRequestType,
+                             base::Unretained(delegate_), ignored_type));
+}
+
 // static
 TestRequestInterceptor::JobCallback TestRequestInterceptor::ErrorJob(
     int error) {
   return base::Bind(&ErrorJobCallback, error);
 }
 
 // static
 TestRequestInterceptor::JobCallback TestRequestInterceptor::BadRequestJob() {
   return base::Bind(&BadRequestJobCallback);
 }
 
 // static
 TestRequestInterceptor::JobCallback TestRequestInterceptor::RegisterJob(
     em::DeviceRegisterRequest::Type expected_type,
     bool expect_reregister) {
   return base::Bind(&RegisterJobCallback, expected_type, expect_reregister);
 }
 
 // static
 TestRequestInterceptor::JobCallback TestRequestInterceptor::FileJob(
     const base::FilePath& file_path) {
   return base::Bind(&FileJobCallback, file_path);
 }
 
+// static
+TestRequestInterceptor::JobCallback
+TestRequestInterceptor::FetchRemoteCommandsJob(
+    TestingRemoteCommandsServer* server,
+    size_t expected_command_results,
+    size_t expected_fetched_commands) {
+  return base::Bind(&FetchRemoteCommandsJobCallback, server,
+                    expected_command_results, expected_fetched_commands);
+}
+
 void TestRequestInterceptor::PostToIOAndWait(const base::Closure& task) {
   io_task_runner_->PostTask(FROM_HERE, task);
   base::RunLoop run_loop;
   io_task_runner_->PostTask(
       FROM_HERE,
       base::Bind(
           base::IgnoreResult(&base::MessageLoopProxy::PostTask),
           base::MessageLoopProxy::current(),
           FROM_HERE,
           run_loop.QuitClosure()));
   run_loop.Run();
 }
 
 }  // namespace policy