Initial RemoteCommandService

components/policy/core/common/cloud/cloud_policy_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/policy/core/common/cloud/cloud_policy_client.h"
 
 #include "base/bind.h"
 #include "base/guid.h"
 #include "base/logging.h"
 #include "base/stl_util.h"
@@ skipping 281 matching lines @@
   DeviceManagementRequestJob::Callback job_callback = base::Bind(
       &CloudPolicyClient::OnStatusUploadCompleted,
       base::Unretained(this),
       request_job.get(),
       callback);
 
   request_jobs_.push_back(request_job.Pass());
   request_jobs_.back()->Start(job_callback);
 }
 
+void CloudPolicyClient::FetchRemoteCommands(
+    RemoteCommandJob::UniqueIDType last_command_id,
+    const std::vector<em::RemoteCommandResult>& command_results,
+    const RemoteCommandCallback& callback) {
+  CHECK(is_registered());
+  scoped_ptr<DeviceManagementRequestJob> request_job(service_->CreateJob(
+      DeviceManagementRequestJob::TYPE_REMOTE_COMMANDS, GetRequestContext()));
+
+  request_job->SetDMToken(dm_token_);
+  request_job->SetClientID(client_id_);
+
+  em::DeviceRemoteCommandRequest* request =
+      request_job->GetRequest()->mutable_remote_command_request();
+
+  request->set_last_command_unique_id(last_command_id);
+  request->clear_command_results();

[bartfab (slow), 2015/02/12 14:29:19]

This is unnecessary. The command results will always start out empty.

[binjin, 2015/02/16 22:46:23]

Done.

+
+  for (const auto& command_result : command_results)
+    *request->add_command_results() = command_result;
+
+  request_jobs_.push_back(request_job.Pass());
+  request_jobs_.back()->Start(
+      base::Bind(&CloudPolicyClient::OnRemoteCommandsFetched,
+                 base::Unretained(this), request_job.get(), callback));
+}
+
 void CloudPolicyClient::AddObserver(Observer* observer) {
   observers_.AddObserver(observer);
 }
 
 void CloudPolicyClient::RemoveObserver(Observer* observer) {
   observers_.RemoveObserver(observer);
 }
 
 void CloudPolicyClient::AddPolicyTypeToFetch(
     const std::string& policy_type,
@@ skipping 197 matching lines @@
     const enterprise_management::DeviceManagementResponse& response) {
   status_ = status;
   if (status != DM_STATUS_SUCCESS)
     NotifyClientError();
 
   callback.Run(status == DM_STATUS_SUCCESS);
   // Must call RemoveJob() last, because it frees |callback|.
   RemoveJob(job);
 }
 
+void CloudPolicyClient::OnRemoteCommandsFetched(
+    const DeviceManagementRequestJob* job,
+    const RemoteCommandCallback& callback,
+    DeviceManagementStatus status,
+    int net_error,
+    const enterprise_management::DeviceManagementResponse& response) {
+  std::vector<enterprise_management::RemoteCommand> commands;
+  if (status == DM_STATUS_SUCCESS && response.has_remote_command_response()) {
+    for (const auto& command : response.remote_command_response().commands())
+      commands.push_back(command);
+  } else {
+    NotifyClientError();
+  }
+  callback.Run(commands);
+}

[bartfab (slow), 2015/02/12 14:29:19]

You forgot to RemoveJob(job).

[binjin, 2015/02/16 22:46:23]

Done.

+
 void CloudPolicyClient::NotifyPolicyFetched() {
   FOR_EACH_OBSERVER(Observer, observers_, OnPolicyFetched(this));
 }
 
 void CloudPolicyClient::NotifyRegistrationStateChanged() {
   FOR_EACH_OBSERVER(Observer, observers_, OnRegistrationStateChanged(this));
 }
 
 void CloudPolicyClient::NotifyRobotAuthCodesFetched() {
   FOR_EACH_OBSERVER(Observer, observers_, OnRobotAuthCodesFetched(this));
 }
 
 void CloudPolicyClient::NotifyClientError() {
   FOR_EACH_OBSERVER(Observer, observers_, OnClientError(this));
 }
 
 }  // namespace policy