Initial RemoteCommandService

chrome/browser/policy/cloud/test_request_interceptor.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_POLICY_CLOUD_TEST_REQUEST_INTERCEPTOR_H_
 #define CHROME_BROWSER_POLICY_CLOUD_TEST_REQUEST_INTERCEPTOR_H_
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/callback.h"
 #include "base/memory/ref_counted.h"
 #include "policy/proto/device_management_backend.pb.h"
 
 namespace base {
 class FilePath;
 class SequencedTaskRunner;
 }
 
 namespace net {
 class NetworkDelegate;
 class URLRequest;
 class URLRequestJob;
 }
 
 namespace policy {
 
+class TestingRemoteCommandsServer;
+
 // Intercepts all requests to the given hostname while in scope, and allows
 // queuing callbacks to handle expected requests. Must be created and destroyed
 // while the IO thread is valid.
 class TestRequestInterceptor {
  public:
   // A callback that returns a new URLRequestJob given a URLRequest.
   // This is used to queue callbacks that will handle expected requests.
+  // If a null URLRequestJob is returned by this callback, it indicates that

[bartfab (slow), 2015/02/12 14:29:17]

The grammar is a bit off in this comment, but that is easily fixable.

I am more concerned about the logic. IIUC, you want to handle the case where
multiple requests arrive in undefined order. Correct? If so, I think we have two
options to handle this cleanly:
1) Instead of magically using a BadRequestJob, simply step through the callback
queue until a callback is found which can handle the current job.
2) Alternatively, make sure that requests are issued in the expected order.

[binjin, 2015/02/16 22:46:22]

It's not for out of order packets. It's meant to ignore certain type of packets,
treating them as illegal requests instead.

[bartfab (slow), 2015/02/17 18:13:52]

If the order in which requests arrive is well-defined, why can you not enqueue
handlers for all of them? For the requests that you do not care about, the
handler can just be a no-op.

[binjin, 2015/02/18 15:37:48]

I don't want to handle certain request (policy request in this case) at all,
since I need to construct a valid and empty response to stop the clients from
retrying policy fetching.

+  // the request is legal but not expected be intercepted by current JobCallback
+  // , thus it will be ignored and BadRequestJob will be used instead for
+  // current request. In the other hand, the current JobCallback will continue
+  // to live in the queue to service future request job.
   typedef base::Callback<
       net::URLRequestJob*(net::URLRequest*, net::NetworkDelegate*)> JobCallback;
 
   // Will intercept request to |hostname| made over HTTP.
   TestRequestInterceptor(
       const std::string& hostname,
       scoped_refptr<base::SequencedTaskRunner> io_task_runner);
   virtual ~TestRequestInterceptor();
 
   // Returns the number of pending callback jobs that haven't been used yet.
@@ skipping 19 matching lines @@
   // |expected_type| is the expected type in the register request.
   // If |expect_reregister| is true then the request must have the reregister
   // flag set; otherwise the flag must be not set.
   static JobCallback RegisterJob(
       enterprise_management::DeviceRegisterRequest::Type expected_type,
       bool expect_reregister);
 
   // Returns a JobCallback that will send the contents of |file_path|.
   static JobCallback FileJob(const base::FilePath& file_path);
 
+  // XXX
+  static JobCallback FetchRemoteCommandsJob(TestingRemoteCommandsServer* server,
+                                            bool ignore_other_requests);
+
  private:
   class Delegate;
 
   // Helper to execute a |task| on IO, and return only after it has completed.
   void PostToIOAndWait(const base::Closure& task);
 
   const std::string hostname_;
 
   scoped_refptr<base::SequencedTaskRunner> io_task_runner_;
 
   // Owned by URLRequestFilter. This handle is valid on IO and only while the
   // interceptor is valid.
   Delegate* delegate_;
 
   DISALLOW_COPY_AND_ASSIGN(TestRequestInterceptor);
 };
 
 }  // namespace policy
 
 #endif  // CHROME_BROWSER_POLICY_CLOUD_TEST_REQUEST_INTERCEPTOR_H_