Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 879223002: Re-add kUseGpuInTests flag in WebRTC browser tests. (Closed)

Created:
5 years, 11 months ago by kjellander_chromium
Modified:
5 years, 10 months ago
Reviewers:
phoglund_chromium
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-add kUseGpuInTests flag in WebRTC browser tests. This reverts the removal of the kUseGpuInTests flags done in https://crrev.com/cf04d9696a7f1f321294bc0970037ddb23c1204d since it seems this affected performance results. It also adds it to the new chrome/browser/media/chrome_webrtc_simulcast_browsertest.cc test. BUG=452654, 452655 Committed: https://crrev.com/0d6e89ba9d5d66adf5dcd8c46682c5a1901844c3 Cr-Commit-Position: refs/heads/master@{#313475}

Patch Set 1 #

Patch Set 2 : Added it to chrome/browser/media/chrome_webrtc_simulcast_browsertest.cc as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/media/chrome_webrtc_simulcast_browsertest.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
kjellander_chromium
Do you think we need to add the flag for chrome/browser/media/chrome_webrtc_simulcast_browsertest.cc as well? I had ...
5 years, 11 months ago (2015-01-28 08:14:58 UTC) #2
phoglund_chromium
lgtm
5 years, 10 months ago (2015-01-28 08:46:56 UTC) #3
phoglund_chromium
On 2015/01/28 08:14:58, kjellander wrote: > Do you think we need to add the flag ...
5 years, 10 months ago (2015-01-28 08:47:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879223002/20001
5 years, 10 months ago (2015-01-28 08:57:14 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-28 10:53:05 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 10:53:52 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0d6e89ba9d5d66adf5dcd8c46682c5a1901844c3
Cr-Commit-Position: refs/heads/master@{#313475}

Powered by Google App Engine
This is Rietveld 408576698