Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5093)

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 879213005: [Extensions Toolbar] Don't show the "show button" for hidden browser actions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
index f3993b5c273d1a9e6fb9139cd5181ddd5711d663..a62d206aee7cdecef398f8c61674f8f13d69d5c1 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
@@ -400,7 +400,11 @@ base::DictionaryValue* ExtensionSettingsHandler::CreateExtensionDetailValue(
else
extension_data->SetInteger("order", 2);
- if (!ExtensionActionAPI::GetBrowserActionVisibility(prefs, extension->id())) {
+ // Don't show the "show button" for the browser action if the toolbar
+ // redesign is enabled, because "hidden" buttons are now just hidden in the
+ // wrench menu.
+ if (!ExtensionActionAPI::GetBrowserActionVisibility(prefs, extension->id()) &&
+ !FeatureSwitch::extension_action_redesign()->IsEnabled()) {
extension_data->SetBoolean("enable_show_button", true);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698