Issue 879213005: [Extensions Toolbar] Don't show the "show button" for hidden browser actions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 879213005: [Extensions Toolbar] Don't show the "show button" for hidden browser actions (Closed)

Created:
5 years, 10 months ago by Devlin

Modified:
5 years, 10 months ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Extensions Toolbar] Don't show the "show button" for hidden browser actions Since browser actions that are hidden are now just overflowed to the wrench menu, we don't really need the show button anymore. BUG=453152 Committed: https://crrev.com/b3ddfb4af4371a002f544f1ee7fc3f15e6a016fc Cr-Commit-Position: refs/heads/master@{#313645}

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	chrome/browser/ui/webui/extensions/extension_settings_handler.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879213005/1

5 years, 10 months ago (2015-01-29 01:02:29 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-01-29 01:17:08 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/b3ddfb4af4371a002f544f1ee7fc3f15e6a016fc
Cr-Commit-Position: refs/heads/master@{#313645}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages