Source/platform/scroll/ScrollableArea.cpp - Issue 879163002: Hook up window.scrollTo and friends.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/scroll/ScrollableArea.cpp

Issue 879163002: Hook up window.scrollTo and friends. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@sa

Patch Set: rebase Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/scroll/ScrollableArea.cpp

diff --git a/Source/platform/scroll/ScrollableArea.cpp b/Source/platform/scroll/ScrollableArea.cpp

index 367f42821331120cd81245fa9289770ebf7286a2..5aea749d456b565856dbdc8d7a6a5161eb5b0949 100644

--- a/Source/platform/scroll/ScrollableArea.cpp

+++ b/Source/platform/scroll/ScrollableArea.cpp

@@ -159,6 +159,12 @@ bool ScrollableArea::scroll(ScrollDirection direction, ScrollGranularity granula

return scrollAnimator()->scroll(orientation, granularity, step, delta);

}

+void ScrollableArea::setScrollPosition(const DoublePoint& position, ScrollBehavior behavior)

+ // FIXME(417782): This should be unified with RenderLayerScrollableArea::scrollToOffset.

+ ASSERT_NOT_REACHED();

void ScrollableArea::scrollToOffsetWithoutAnimation(const FloatPoint& offset, bool cancelProgrammaticAnimations)

{

if (cancelProgrammaticAnimations)