Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 879153002: Instrumenting more of WM_ message processing for jank (Closed)

Created:
5 years, 11 months ago by vadimt
Modified:
5 years, 10 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, tfarina, erikwright+watch_chromium.org, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Instrumenting more of WM_ message processing for jank This covers some Omnibox stuff, which is probably responsible for the jank in keyboard messages processing and drilling down some of issues. There are some issues that require advanced investigations that are not included in this CL: 1. PeekMessage, which is probably processing hooks 2. DispatchMessage, maybe, having same issues 3. GetQueueStatus (!!!) 4. DefWndProc BUG=440919 Committed: https://crrev.com/2e7c444831ca184786cd5ceaf06875f3a2672f44 Cr-Commit-Position: refs/heads/master@{#313529}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -3 lines) Patch
M base/message_loop/message_pump_win.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_edit_model.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M ui/views/win/hwnd_message_handler.cc View 3 chunks +26 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
vadimt
cpu@, please review
5 years, 11 months ago (2015-01-28 01:55:20 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm the omnibox is going to spawn a renderer to render stuff so I expect ...
5 years, 11 months ago (2015-01-28 02:50:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879153002/1
5 years, 10 months ago (2015-01-28 15:24:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-28 16:58:12 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 16:58:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e7c444831ca184786cd5ceaf06875f3a2672f44
Cr-Commit-Position: refs/heads/master@{#313529}

Powered by Google App Engine
This is Rietveld 408576698