content/renderer/render_view_impl.cc - Issue 879143002: Avoid crashing if multiple target popup is empty.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.cc

Issue 879143002: Avoid crashing if multiple target popup is empty. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_view_impl.cc

diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc

index 6f5017dfb27f58028d73ae7713385361c7d4a576..5890d6622daae00895119eec6b792e154465046c 100644

--- a/content/renderer/render_view_impl.cc

+++ b/content/renderer/render_view_impl.cc

@@ -3954,6 +3954,10 @@ bool RenderViewImpl::didTapMultipleTargets(

RenderThreadImpl::current()->shared_bitmap_manager();

scoped_ptr<cc::SharedBitmap> shared_bitmap =

manager->AllocateSharedBitmap(canvas_size);

+ if (!shared_bitmap) {

no sievers 2015/01/28 18:26:23 nit: consider if (shared_bitmap) {line 3961-3996}

no sievers 2015/01/30 02:09:29 and maybe this nit

+ handled = false;

+ break;

+ }

{

SkBitmap bitmap;

SkImageInfo info = SkImageInfo::MakeN32Premul(canvas_size.width(),

« no previous file with comments | « no previous file | no next file » | no next file with comments »