Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: pkg/analyzer/lib/src/generated/element_resolver.dart

Issue 879093002: Fix mixin resolution order when multiple mixins present. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/generated/element.dart ('k') | pkg/analyzer/lib/src/generated/resolver.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/element_resolver.dart
diff --git a/pkg/analyzer/lib/src/generated/element_resolver.dart b/pkg/analyzer/lib/src/generated/element_resolver.dart
index 2b5bf19248198084e99a56dfee067c1dcd5e8bf4..9ecb2326b4d8b118b945590aff58b7a704ecf0cb 100644
--- a/pkg/analyzer/lib/src/generated/element_resolver.dart
+++ b/pkg/analyzer/lib/src/generated/element_resolver.dart
@@ -1706,7 +1706,7 @@ class ElementResolver extends SimpleAstVisitor<Object> {
return getter;
}
}
- for (InterfaceType mixinType in targetType.mixins) {
+ for (InterfaceType mixinType in targetType.mixins.reversed) {
PropertyAccessorElement getter =
_lookUpGetterInInterfaces(mixinType, true, getterName, visitedInterfaces);
if (getter != null) {
@@ -1799,7 +1799,7 @@ class ElementResolver extends SimpleAstVisitor<Object> {
return member;
}
}
- for (InterfaceType mixinType in targetType.mixins) {
+ for (InterfaceType mixinType in targetType.mixins.reversed) {
ExecutableElement member = _lookUpGetterOrMethodInInterfaces(
mixinType,
true,
@@ -1897,7 +1897,7 @@ class ElementResolver extends SimpleAstVisitor<Object> {
return method;
}
}
- for (InterfaceType mixinType in targetType.mixins) {
+ for (InterfaceType mixinType in targetType.mixins.reversed) {
MethodElement method =
_lookUpMethodInInterfaces(mixinType, true, methodName, visitedInterfaces);
if (method != null) {
@@ -2018,7 +2018,7 @@ class ElementResolver extends SimpleAstVisitor<Object> {
return setter;
}
}
- for (InterfaceType mixinType in targetType.mixins) {
+ for (InterfaceType mixinType in targetType.mixins.reversed) {
PropertyAccessorElement setter =
_lookUpSetterInInterfaces(mixinType, true, setterName, visitedInterfaces);
if (setter != null) {
« no previous file with comments | « pkg/analyzer/lib/src/generated/element.dart ('k') | pkg/analyzer/lib/src/generated/resolver.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698