Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 879073002: Chromecast Android buildfix: use new ContentViewCore.initialize API. (Closed)

Created:
5 years, 10 months ago by gunsch
Modified:
5 years, 10 months ago
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chromecast Android buildfix: use new ContentViewCore.initialize API. See: https://codereview.chromium.org/831523005 R=dtrainor@chromium.org,lcwu@chromium.org BUG=None Committed: https://crrev.com/d6a9562f0f84619a12d2c259aece8f6574defaa2 Cr-Commit-Position: refs/heads/master@{#313391}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWindowAndroid.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chromecast/browser/android/cast_window_android.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
gunsch
5 years, 10 months ago (2015-01-27 22:17:51 UTC) #1
David Trainor- moved to gerrit
lgtm. Sorry if I missed this!
5 years, 10 months ago (2015-01-27 22:23:14 UTC) #2
gunsch
not at all, it's our fault we don't have a trybot yet :)
5 years, 10 months ago (2015-01-27 22:24:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879073002/1
5 years, 10 months ago (2015-01-27 22:25:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-27 23:03:43 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-27 23:05:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d6a9562f0f84619a12d2c259aece8f6574defaa2
Cr-Commit-Position: refs/heads/master@{#313391}

Powered by Google App Engine
This is Rietveld 408576698