Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 879053006: Revert "Only use externally provided args for external apps" (Closed)

Created:
5 years, 10 months ago by DaveMoore
Modified:
5 years, 10 months ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Revert "Only use externally provided args for external apps" This reverts commit 34bc708c46816ec5e03d257b2e732c899a1d40b9. This broke ExampleApplicationTest.CheckCommandLineArg BUG= TBR=qsr Committed: https://chromium.googlesource.com/external/mojo/+/05e64302075901556d7df810b741b456503ea48c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M shell/application_manager/application_manager.cc View 2 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
DaveMoore
Committed patchset #1 (id:1) manually as 05e64302075901556d7df810b741b456503ea48c (presubmit successful).
5 years, 10 months ago (2015-01-28 14:39:20 UTC) #1
qsr
5 years, 10 months ago (2015-01-28 14:41:56 UTC) #2
Message was sent while issue was closed.
LGTM Thanks.

Powered by Google App Engine
This is Rietveld 408576698