Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1137)

Unified Diff: components/omnibox/omnibox_field_trial.h

Issue 879053002: Remove Omnibox Disallow Inlining Field Trial (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: revise histogram obsolete message Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/omnibox/autocomplete_result_unittest.cc ('k') | components/omnibox/omnibox_field_trial.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/omnibox/omnibox_field_trial.h
diff --git a/components/omnibox/omnibox_field_trial.h b/components/omnibox/omnibox_field_trial.h
index 5a8909d172489ade27b21470a45848ff51902464..5a439e2f384a6dd62e2d1a5ceba56938d58b8325 100644
--- a/components/omnibox/omnibox_field_trial.h
+++ b/components/omnibox/omnibox_field_trial.h
@@ -240,18 +240,6 @@ class OmniboxFieldTrial {
static bool HQPAllowMatchInSchemeValue();
// ---------------------------------------------------------
- // For the DisableInlining experiment that's part of the bundled omnibox
- // field trial.
-
- // Returns true if AutocompleteResult should prevent any suggestion with
- // a non-empty |inline_autocomplete| from being the default match. In
- // other words, prevent an inline autocompletion from appearing as the
- // top suggestion / within the omnibox itself, reordering matches as
- // necessary to make this true. Returns false if the experiment isn't
- // active.
- static bool DisableInlining();
-
- // ---------------------------------------------------------
// For the AnswersInSuggest experiment that's part of the bundled omnibox
// field trial.
@@ -262,20 +250,6 @@ class OmniboxFieldTrial {
static bool EnableAnswersInSuggest();
// ---------------------------------------------------------
- // For the AddUWYTMatchEvenIfPromotedURLs experiment that's part of the
- // bundled omnibox field trial.
-
- // Returns true if HistoryURL Provider should add the URL-what-you-typed match
- // (if valid and reasonable) even if the provider has good inline
- // autocompletions to offer. Normally HistoryURL does not add the UWYT match
- // if there are good inline autocompletions, as the user could simply hit
- // backspace to delete the completion and get the what-you-typed match.
- // However, for the disabling inlining experiment we want to have the UWYT
- // always explicitly displayed at an option if possible. Returns false if
- // the experiment isn't active.
- static bool AddUWYTMatchEvenIfPromotedURLs();
-
- // ---------------------------------------------------------
// For the DisplayHintTextWhenPossible experiment that's part of the
// bundled omnibox field trial.
@@ -309,9 +283,7 @@ class OmniboxFieldTrial {
static const char kHQPAllowMatchInSchemeRule[];
static const char kZeroSuggestRule[];
static const char kZeroSuggestVariantRule[];
- static const char kDisableInliningRule[];
static const char kAnswersInSuggestRule[];
- static const char kAddUWYTMatchEvenIfPromotedURLsRule[];
static const char kDisplayHintTextWhenPossibleRule[];
static const char kDisableResultsCachingRule[];
static const char kMeasureSuggestPollingDelayFromLastKeystrokeRule[];
« no previous file with comments | « components/omnibox/autocomplete_result_unittest.cc ('k') | components/omnibox/omnibox_field_trial.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698