Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: chrome/browser/autocomplete/history_url_provider.h

Issue 879053002: Remove Omnibox Disallow Inlining Field Trial (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/history_url_provider.h
diff --git a/chrome/browser/autocomplete/history_url_provider.h b/chrome/browser/autocomplete/history_url_provider.h
index ac3e8947c98619ee8820bd39bf779b4d8678f069..19ee8e6b49389674a8c9302262870626cc3235f9 100644
--- a/chrome/browser/autocomplete/history_url_provider.h
+++ b/chrome/browser/autocomplete/history_url_provider.h
@@ -157,11 +157,6 @@ struct HistoryURLProviderParams {
// this to. See comments in DoAutocomplete().
PromoteType promote_type;
- // True if |what_you_typed_match| is eligible for display. If this is true,
- // PromoteMatchesIfNecessary() may choose to place |what_you_typed_match| on
- // |matches_| even when |promote_type| is not WHAT_YOU_TYPED_MATCH.
- bool have_what_you_typed_match;
-
// Languages we should pass to gfx::GetCleanStringFromUrl.
std::string languages;
@@ -250,10 +245,10 @@ class HistoryURLProvider : public HistoryProvider {
history::URLDatabase* db,
HistoryURLProviderParams* params);
- // May promote the what you typed match, the first history match in
- // parmas->matches, or both to the front of |matches_|, depending on the
- // values of params->promote_type and params->have_what_you_typed_match.
- void PromoteMatchesIfNecessary(const HistoryURLProviderParams& params);
+ // May promote either the what you typed match or first history match in
+ // params->matches to the front of |matches_|, depending on the value of
+ // params->promote_type.
+ void PromoteMatchIfNecessary(const HistoryURLProviderParams& params);
// Dispatches the results to the autocomplete controller. Called on the
// main thread by ExecuteWithDB when the results are available.
« no previous file with comments | « no previous file | chrome/browser/autocomplete/history_url_provider.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698