Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 879053002: Remove Omnibox Disallow Inlining Field Trial (Closed)

Created:
5 years, 11 months ago by Mark P
Modified:
5 years, 11 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, James Su, asvitkine+watch_chromium.org, Maria
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Omnibox Disallow Inlining Field Trial The results are summarized here: goto/disallow-inlining-trial-results This is effectively a revert of https://src.chromium.org/viewvc/chrome?revision=273966&view=revision and http://src.chromium.org/viewvc/chrome?view=revision&revision=278811 BUG= Committed: https://crrev.com/43e0be280bb85a00d8611ea16b71f810ce0d98c1 Cr-Commit-Position: refs/heads/master@{#313375}

Patch Set 1 #

Total comments: 2

Patch Set 2 : revise histogram obsolete message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -272 lines) Patch
M chrome/browser/autocomplete/history_url_provider.h View 2 chunks +4 lines, -9 lines 0 comments Download
M chrome/browser/autocomplete/history_url_provider.cc View 6 chunks +13 lines, -18 lines 0 comments Download
M components/omnibox/autocomplete_result.cc View 3 chunks +2 lines, -36 lines 0 comments Download
M components/omnibox/autocomplete_result_unittest.cc View 1 chunk +0 lines, -166 lines 0 comments Download
M components/omnibox/omnibox_field_trial.h View 3 chunks +0 lines, -28 lines 0 comments Download
M components/omnibox/omnibox_field_trial.cc View 3 chunks +0 lines, -15 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Mark P
Easy peasy. Peter, please take a look. --mark
5 years, 11 months ago (2015-01-27 20:27:35 UTC) #2
Peter Kasting
LGTM https://codereview.chromium.org/879053002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/879053002/diff/1/tools/metrics/histograms/histograms.xml#newcode22414 tools/metrics/histograms/histograms.xml:22414: + effect while doing its primary purpose. This ...
5 years, 11 months ago (2015-01-27 20:35:10 UTC) #3
Mark P
https://codereview.chromium.org/879053002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/879053002/diff/1/tools/metrics/histograms/histograms.xml#newcode22414 tools/metrics/histograms/histograms.xml:22414: + effect while doing its primary purpose. On 2015/01/27 ...
5 years, 11 months ago (2015-01-27 21:15:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879053002/20001
5 years, 11 months ago (2015-01-27 21:16:16 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-27 22:13:44 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 22:15:54 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/43e0be280bb85a00d8611ea16b71f810ce0d98c1
Cr-Commit-Position: refs/heads/master@{#313375}

Powered by Google App Engine
This is Rietveld 408576698