Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 879033003: Fix experimental app list's start page logo not showing in Guest Mode. (Closed)

Created:
5 years, 10 months ago by calamity
Modified:
5 years, 10 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_search_results_not_being_there
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix experimental app list's start page logo not showing in Guest Mode. This CL fixes an issue with the app list not showing the start page logo in ChromeOS Guest Mode. This was happening because no start page service was being created for incognito contexts. This will also cause voice search to be enabled in the app list in Guest Mode. BUG=440484 Committed: https://crrev.com/64121b7f8233a309b0f818269a5049976ba37e3c Cr-Commit-Position: refs/heads/master@{#315272}

Patch Set 1 #

Patch Set 2 : fix for test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M chrome/browser/ui/app_list/app_list_service_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/start_page_service_factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/start_page_service_factory.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
calamity
5 years, 10 months ago (2015-02-09 02:30:06 UTC) #2
Matt Giuca
lgtm
5 years, 10 months ago (2015-02-09 03:05:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879033003/1
5 years, 10 months ago (2015-02-09 03:55:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/22798)
5 years, 10 months ago (2015-02-09 04:53:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879033003/20001
5 years, 10 months ago (2015-02-09 06:12:40 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-09 06:33:02 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 06:33:38 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/64121b7f8233a309b0f818269a5049976ba37e3c
Cr-Commit-Position: refs/heads/master@{#315272}

Powered by Google App Engine
This is Rietveld 408576698