Issue 879003: Fix resolution independence in theming. Improve from "pretty broken" to "brok...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 879003: Fix resolution independence in theming. Improve from "pretty broken" to "brok... (Closed)

Created:
10 years, 9 months ago by Avi (use Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
Nico

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix resolution independence in theming. Improve from "pretty broken" to "broken but pretty". BUG=http://crbug.com/19476 TEST=run in RI and see themes. Still broken a bit but a lot better. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41437

Patch Set 1 #

Total comments: 1

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -7 lines)			Patch
	M	chrome/browser/cocoa/browser_frame_view.mm	View		3 chunks	+14 lines, -7 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nico

10 years, 9 months ago (2010-03-11 23:38:31 UTC) #2

LG

http://codereview.chromium.org/879003/diff/1/2
File chrome/browser/cocoa/browser_frame_view.mm (right):

http://codereview.chromium.org/879003/diff/1/2#newcode242
chrome/browser/cocoa/browser_frame_view.mm:242: phase = [view
convertPointFromBase:phase];
:-)

Expand Messages | Collapse Messages