Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8790002: Re-committing http://codereview.chromium.org/8736001/ originally committed revision=112305 (Closed)

Created:
9 years ago by GeorgeY
Modified:
9 years ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, dhollowa+watch_chromium.org, Ilya Sherman, dyu1, jshin+watch_chromium.org
Visibility:
Public.

Description

Re-committing http://codereview.chromium.org/8736001/ originally committed revision=112305 The difference is the phone library pulled is version 407 instead of 403, it includes fixes, including missing licenses. Original description: Pull the phone library directly. Delete old version. TEST=unit-tests BUG=105577 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112865

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -58433 lines) Patch
M DEPS View 1 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/autofill/phone_number_i18n.cc View 1 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/libphonenumber/README.chromium View 1 2 chunks +10 lines, -12 lines 0 comments Download
D third_party/libphonenumber/cpp/CMakeLists.txt View 1 1 chunk +0 lines, -329 lines 0 comments Download
D third_party/libphonenumber/cpp/LICENSE View 1 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/libphonenumber/cpp/README View 1 1 chunk +0 lines, -91 lines 0 comments Download
D third_party/libphonenumber/cpp/src/default_logger.h View 1 1 chunk +0 lines, -99 lines 0 comments Download
D third_party/libphonenumber/cpp/src/default_logger.cc View 1 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/libphonenumber/cpp/src/encoding_utils.h View 1 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/libphonenumber/cpp/src/lite_metadata.cc View 1 1 chunk +0 lines, -9055 lines 0 comments Download
D third_party/libphonenumber/cpp/src/logger.h View 1 1 chunk +0 lines, -92 lines 0 comments Download
D third_party/libphonenumber/cpp/src/logger.cc View 1 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/libphonenumber/cpp/src/logger_test.cc View 1 1 chunk +0 lines, -104 lines 0 comments Download
D third_party/libphonenumber/cpp/src/metadata.h View 1 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/libphonenumber/cpp/src/metadata.cc View 1 1 chunk +0 lines, -9830 lines 0 comments Download
D third_party/libphonenumber/cpp/src/normalize_utf8.h View 1 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/libphonenumber/cpp/src/phonenumber.h View 1 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/libphonenumber/cpp/src/phonenumber.cc View 1 1 chunk +0 lines, -87 lines 0 comments Download
D third_party/libphonenumber/cpp/src/phonenumberutil.h View 1 1 chunk +0 lines, -647 lines 0 comments Download
D third_party/libphonenumber/cpp/src/phonenumberutil.cc View 1 1 chunk +0 lines, -2177 lines 0 comments Download
D third_party/libphonenumber/cpp/src/phonenumberutil_test.cc View 1 1 chunk +0 lines, -2925 lines 0 comments Download
D third_party/libphonenumber/cpp/src/regexp_adapter.h View 1 1 chunk +0 lines, -162 lines 0 comments Download
D third_party/libphonenumber/cpp/src/regexp_adapter_icu.cc View 1 1 chunk +0 lines, -209 lines 0 comments Download
D third_party/libphonenumber/cpp/src/regexp_adapter_re2.cc View 1 1 chunk +0 lines, -163 lines 0 comments Download
D third_party/libphonenumber/cpp/src/regexp_adapter_test.cc View 1 1 chunk +0 lines, -198 lines 0 comments Download
D third_party/libphonenumber/cpp/src/regexp_cache.h View 1 1 chunk +0 lines, -76 lines 0 comments Download
D third_party/libphonenumber/cpp/src/regexp_cache.cc View 1 1 chunk +0 lines, -60 lines 0 comments Download
D third_party/libphonenumber/cpp/src/regexp_cache_test.cc View 1 1 chunk +0 lines, -57 lines 0 comments Download
D third_party/libphonenumber/cpp/src/region_code.h View 1 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/libphonenumber/cpp/src/run_tests.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/libphonenumber/cpp/src/stl_util.h View 1 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/libphonenumber/cpp/src/stringutil.h View 1 1 chunk +0 lines, -130 lines 0 comments Download
D third_party/libphonenumber/cpp/src/stringutil.cc View 1 1 chunk +0 lines, -298 lines 0 comments Download
D third_party/libphonenumber/cpp/src/stringutil_test.cc View 1 1 chunk +0 lines, -231 lines 0 comments Download
D third_party/libphonenumber/cpp/src/test_metadata.cc View 1 1 chunk +0 lines, -665 lines 0 comments Download
D third_party/libphonenumber/cpp/src/utf/README View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/libphonenumber/cpp/src/utf/rune.c View 1 1 chunk +0 lines, -350 lines 0 comments Download
D third_party/libphonenumber/cpp/src/utf/stringpiece.h View 1 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/libphonenumber/cpp/src/utf/stringprintf.h View 1 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/libphonenumber/cpp/src/utf/unicodetext.h View 1 1 chunk +0 lines, -456 lines 0 comments Download
D third_party/libphonenumber/cpp/src/utf/unicodetext.cc View 1 1 chunk +0 lines, -515 lines 0 comments Download
D third_party/libphonenumber/cpp/src/utf/unicodetext_test.cc View 1 1 chunk +0 lines, -45 lines 0 comments Download
D third_party/libphonenumber/cpp/src/utf/unilib.h View 1 1 chunk +0 lines, -95 lines 0 comments Download
D third_party/libphonenumber/cpp/src/utf/unilib.cc View 1 1 chunk +0 lines, -64 lines 0 comments Download
D third_party/libphonenumber/cpp/src/utf/utf.h View 1 1 chunk +0 lines, -251 lines 0 comments Download
D third_party/libphonenumber/cpp/src/utf/utfdef.h View 1 1 chunk +0 lines, -28 lines 0 comments Download
M third_party/libphonenumber/libphonenumber.gyp View 1 3 chunks +38 lines, -26 lines 0 comments Download
D third_party/libphonenumber/resources/PhoneNumberMetaData.xml View 1 1 chunk +0 lines, -20321 lines 0 comments Download
D third_party/libphonenumber/resources/PhoneNumberMetaDataForTesting.xml View 1 1 chunk +0 lines, -730 lines 0 comments Download
D third_party/libphonenumber/resources/geocoding/de/43.txt View 1 1 chunk +0 lines, -1037 lines 0 comments Download
D third_party/libphonenumber/resources/geocoding/de/49.txt View 1 1 chunk +0 lines, -3528 lines 0 comments Download
D third_party/libphonenumber/resources/geocoding/en/1.txt View 1 1 chunk +0 lines, -316 lines 0 comments Download
D third_party/libphonenumber/resources/geocoding/en/44.txt View 1 1 chunk +0 lines, -853 lines 0 comments Download
D third_party/libphonenumber/resources/geocoding/en/82.txt View 1 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/libphonenumber/resources/geocoding/es/34.txt View 1 1 chunk +0 lines, -100 lines 0 comments Download
D third_party/libphonenumber/resources/geocoding/es/54.txt View 1 1 chunk +0 lines, -225 lines 0 comments Download
D third_party/libphonenumber/resources/geocoding/es/56.txt View 1 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/libphonenumber/resources/geocoding/ko/82.txt View 1 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/libphonenumber/resources/geocoding/nl/31.txt View 1 1 chunk +0 lines, -135 lines 0 comments Download
D third_party/libphonenumber/resources/geocoding/pt/55.txt View 1 1 chunk +0 lines, -77 lines 0 comments Download
D third_party/libphonenumber/resources/geocoding/sv/46.txt View 1 1 chunk +0 lines, -266 lines 0 comments Download
D third_party/libphonenumber/resources/geocoding/zh/82.txt View 1 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/libphonenumber/resources/geocoding/zh/86.txt View 1 1 chunk +0 lines, -339 lines 0 comments Download
D third_party/libphonenumber/resources/geocoding/zh_Hant/82.txt View 1 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/libphonenumber/resources/phonemetadata.proto View 1 1 chunk +0 lines, -235 lines 0 comments Download
D third_party/libphonenumber/resources/phonenumber.proto View 1 1 chunk +0 lines, -121 lines 0 comments Download
D third_party/libphonenumber/resources/test/geocoding/en/1.txt View 1 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/libphonenumber/resources/test/geocoding/en/82.txt View 1 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/libphonenumber/resources/test/geocoding/ko/82.txt View 1 1 chunk +0 lines, -30 lines 0 comments Download
A third_party/libphonenumber/src/LICENSE View 1 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/libphonenumber/src/phonenumber_api.h View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
GeorgeY
Also, fixes relevant to this CL: http://codereview.chromium.org/8774026/ (Committed) http://codereview.chromium.org/8769025/ (Committed)
9 years ago (2011-12-02 23:27:13 UTC) #1
Ilya Sherman
LGTM, thanks http://codereview.chromium.org/8790002/diff/1/third_party/libphonenumber/README.chromium File third_party/libphonenumber/README.chromium (right): http://codereview.chromium.org/8790002/diff/1/third_party/libphonenumber/README.chromium#newcode5 third_party/libphonenumber/README.chromium:5: Revision: 403 nit: 407?
9 years ago (2011-12-02 23:29:16 UTC) #2
GeorgeY
On 2011/12/02 23:29:16, Ilya Sherman wrote: > LGTM, thanks > > http://codereview.chromium.org/8790002/diff/1/third_party/libphonenumber/README.chromium > File third_party/libphonenumber/README.chromium ...
9 years ago (2011-12-02 23:34:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/georgey@chromium.org/8790002/8001
9 years ago (2011-12-03 01:23:39 UTC) #4
commit-bot: I haz the power
Change committed as 112865
9 years ago (2011-12-03 04:19:26 UTC) #5
M-A Ruel
9 years ago (2011-12-13 03:12:51 UTC) #6 
On 2011/12/03 04:19:26, I haz the power (commit-bot) wrote:
> Change committed as 112865

Note that this CL forces all the try slaves to re-checkout this library because
svn:ignore wasn't updated. Fixing.

Powered by Google App Engine
This is Rietveld 408576698