Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 878933003: Move the apptest runner and parts of mopy to the public SDK. (Closed)

Created:
5 years, 10 months ago by ppi
Modified:
5 years, 10 months ago
Reviewers:
msw, jamesr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, jamesr, viettrungluu
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Move the apptest runner and parts of mopy to the public SDK. Apptest runner is useful for any party that needs to run apptests. In particular, we want it to be available in Chromium, where html_viewer and network service are developed. This patch moves the apptest runner along with the relevant parts of mopy to the public SDK. The remainings of mopy become mopy_internal. BUG=450356

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1481 lines) Patch
A + mojo/public/tools/apptest_runner.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/mopy/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/mopy/android.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/mopy/background_app_group.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/mopy/config.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/mopy/gn.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/mopy/gn_unittest.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/mopy/gtest.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/mopy/gtest_list_tests_unittest.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/mopy/paths.py View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/tools/mopy/print_process_error.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A mojo/tools/add_sdk_tools_to_path.py View 1 chunk +11 lines, -0 lines 0 comments Download
M mojo/tools/android_mojo_shell.py View 1 chunk +3 lines, -1 line 0 comments Download
D mojo/tools/apptest_runner.py View 1 chunk +0 lines, -115 lines 0 comments Download
M mojo/tools/check_mojom_golden_files.py View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/tools/get_test_list.py View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/tools/mojo_demo.py View 1 chunk +4 lines, -2 lines 0 comments Download
M mojo/tools/mojob.py View 1 chunk +3 lines, -1 line 0 comments Download
D mojo/tools/mopy/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/tools/mopy/android.py View 1 chunk +0 lines, -208 lines 0 comments Download
D mojo/tools/mopy/background_app_group.py View 1 chunk +0 lines, -157 lines 0 comments Download
D mojo/tools/mopy/config.py View 1 chunk +0 lines, -121 lines 0 comments Download
D mojo/tools/mopy/file_hash.py View 1 chunk +0 lines, -26 lines 0 comments Download
D mojo/tools/mopy/gn.py View 1 chunk +0 lines, -123 lines 0 comments Download
D mojo/tools/mopy/gn_unittest.py View 1 chunk +0 lines, -68 lines 0 comments Download
D mojo/tools/mopy/gtest.py View 1 chunk +0 lines, -171 lines 0 comments Download
D mojo/tools/mopy/gtest_list_tests_unittest.py View 1 chunk +0 lines, -49 lines 0 comments Download
D mojo/tools/mopy/memoize.py View 1 chunk +0 lines, -18 lines 0 comments Download
D mojo/tools/mopy/mojo_python_tests_runner.py View 1 chunk +0 lines, -52 lines 0 comments Download
D mojo/tools/mopy/paths.py View 1 chunk +0 lines, -63 lines 0 comments Download
D mojo/tools/mopy/perf_data_uploader.py View 1 chunk +0 lines, -191 lines 0 comments Download
D mojo/tools/mopy/print_process_error.py View 1 chunk +0 lines, -22 lines 0 comments Download
D mojo/tools/mopy/transitive_hash.py View 1 chunk +0 lines, -80 lines 0 comments Download
D mojo/tools/mopy/version.py View 1 chunk +0 lines, -14 lines 0 comments Download
A + mojo/tools/mopy_internal/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/tools/mopy_internal/file_hash.py View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/tools/mopy_internal/memoize.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/tools/mopy_internal/mojo_python_tests_runner.py View 1 chunk +1 line, -0 lines 0 comments Download
A + mojo/tools/mopy_internal/perf_data_uploader.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/tools/mopy_internal/transitive_hash.py View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/tools/mopy_internal/version.py View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/tools/perf_test_runner.py View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/tools/run_mojo_python_bindings_tests.py View 1 chunk +1 line, -1 line 0 comments Download
M mojo/tools/run_mojo_python_tests.py View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/tools/test_runner.py View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/tools/upload_shell_binary.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
ppi
Hi James, ptal.
5 years, 10 months ago (2015-01-27 17:45:29 UTC) #4
jamesr
msw@ is responsible for this (iirc) and is back from vacation next week, he should ...
5 years, 10 months ago (2015-01-27 20:54:42 UTC) #6
jamesr
I don't think we should have "mopy" in the public SDK dir. If we want ...
5 years, 10 months ago (2015-01-27 20:55:36 UTC) #8
jamesr
I don't think we should have "mopy" in the public SDK dir. If we want ...
5 years, 10 months ago (2015-01-27 20:55:39 UTC) #9
msw
On 2015/01/27 20:55:39, jamesr wrote: > I don't think we should have "mopy" in the ...
5 years, 10 months ago (2015-02-04 01:47:57 UTC) #10
jamesr
We could probably just move config.py to the public SDK and use it from everywhere ...
5 years, 10 months ago (2015-02-04 03:09:05 UTC) #12
ppi
5 years, 10 months ago (2015-02-04 15:47:55 UTC) #13
This CL is not a good illustration, it was before we had working Android
support. For supporting Linux only we actually don't need much, see the simple
runner we landed for the time being in Chromium:
https://codereview.chromium.org/874273002/ .

To support Android we need mopy/android.py and this in turn depends on
//build/android/pylib for a bunch of stuff. I wrote up
https://docs.google.com/a/chromium.org/document/d/1mQlR_5bLdVxwnI_hFuLwGtk4vr...
listing the dependencies, should we move the discussion to the doc and to the
crbug?

Powered by Google App Engine
This is Rietveld 408576698