scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_asan_rel_ng.json - Issue 878923002: Don't set fastbuild=1 for Mac ASan trybots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_asan_rel_ng.json

Issue 878923002: Don't set fastbuild=1 for Mac ASan trybots. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Move fastbuild=0 to asan() config and retrain Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/chromium.expected/full_chromium_memory_Mac_ASan_64_Tests__1_.json ('k') | scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_mac_asan.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_asan_rel_ng.json

diff --git a/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_asan_rel_ng.json b/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_asan_rel_ng.json

index 45b3b2d292fbee736d08f1be3ff69a604ce194d2..e252f6068e6736140156ac853dca15cd3bca70b3 100644

--- a/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_asan_rel_ng.json

+++ b/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_asan_rel_ng.json

@@ -87,7 +87,7 @@

"runhooks"

"env": {

- "GYP_DEFINES": "asan=1 clang=1 component=static_library dcheck_always_on=1 fastbuild=1 gomadir='[BUILD]/goma' host_arch=x64 target_arch=x64 test_isolation_mode=prepare use_goma=1"

+ "GYP_DEFINES": "asan=1 clang=1 component=static_library dcheck_always_on=1 fastbuild=0 gomadir='[BUILD]/goma' host_arch=x64 target_arch=x64 test_isolation_mode=prepare use_goma=1"

"name": "gclient runhooks (with patch)"

@@ -170,7 +170,7 @@

"/path/to/tmp/json"

"env": {

- "GYP_DEFINES": "asan=1 clang=1 component=static_library dcheck_always_on=1 fastbuild=1 gomadir='[BUILD]/goma' host_arch=x64 target_arch=x64 test_isolation_mode=prepare use_goma=1"

+ "GYP_DEFINES": "asan=1 clang=1 component=static_library dcheck_always_on=1 fastbuild=0 gomadir='[BUILD]/goma' host_arch=x64 target_arch=x64 test_isolation_mode=prepare use_goma=1"

"name": "analyze",

"~followup_annotations": [