scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac64_ASAN.json - Issue 878923002: Don't set fastbuild=1 for Mac ASan trybots.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac64_ASAN.json

Issue 878923002: Don't set fastbuild=1 for Mac ASan trybots. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Move fastbuild=0 to asan() config and retrain Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_mac_asan_xcode61.json ('k') | scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_mac_asan__parallel_.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": [

4 "python",	4 "python",

5 "-u",	5 "-u",

6 "[BUILD]/scripts/slave/bot_update.py",	6 "[BUILD]/scripts/slave/bot_update.py",

7 "--master",	7 "--master",

8 "client.v8",	8 "client.v8",

9 "--builder",	9 "--builder",

10 "V8 Mac64 ASAN",	10 "V8 Mac64 ASAN",

(...skipping 31 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
42 ]	42 ]

43 },	43 },

44 {	44 {

45 "cmd": [	45 "cmd": [

46 "python",	46 "python",

47 "-u",	47 "-u",

48 "[DEPOT_TOOLS]/gclient.py",	48 "[DEPOT_TOOLS]/gclient.py",

49 "runhooks"	49 "runhooks"

50 ],	50 ],

51 "env": {	51 "env": {

52 "GYP_DEFINES": "asan=1 clang=1 lsan=1 target_arch=x64 v8_target_arch=x64"	52 "GYP_DEFINES": "asan=1 clang=1 fastbuild=0 lsan=1 target_arch=x64 v8_targe t_arch=x64"

53 },	53 },

54 "name": "gclient runhooks"	54 "name": "gclient runhooks"

55 },	55 },

56 {	56 {

57 "cmd": [	57 "cmd": [

58 "python",	58 "python",

59 "-u",	59 "-u",

60 "[BUILD]/scripts/slave/cleanup_temp.py"	60 "[BUILD]/scripts/slave/cleanup_temp.py"

61 ],	61 ],

62 "name": "cleanup_temp"	62 "name": "cleanup_temp"

(...skipping 77 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
140 "--json-test-results",	140 "--json-test-results",

141 "/path/to/tmp/json"	141 "/path/to/tmp/json"

142 ],	142 ],

143 "cwd": "[SLAVE_BUILD]/v8",	143 "cwd": "[SLAVE_BUILD]/v8",

144 "env": {	144 "env": {

145 "ASAN_OPTIONS": "external_symbolizer_path=[SLAVE_BUILD]/v8/third_party/llv m-build/Release+Asserts/bin/llvm-symbolizer"	145 "ASAN_OPTIONS": "external_symbolizer_path=[SLAVE_BUILD]/v8/third_party/llv m-build/Release+Asserts/bin/llvm-symbolizer"

146 },	146 },

147 "name": "Check - flaky"	147 "name": "Check - flaky"

148 }	148 }

149 ]	149 ]

OLD	NEW