Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 878913003: Added flag gaia-endpoint for testing with different flows (Closed)

Created:
5 years, 10 months ago by Roman Sorokin (ftl)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added flag gaia-endpoint for testing with different flows BUG=451959 TEST=manual Committed: https://crrev.com/b4e20306b4956cd00a29e7b2b379099897d06826 Cr-Commit-Position: refs/heads/master@{#313700}

Patch Set 1 #

Patch Set 2 : Move switch to chromeos switches #

Total comments: 4

Patch Set 3 : Update after review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M chrome/browser/resources/chromeos/login/screen_gaia_signin.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/chromeos_switches.cc View 1 2 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Roman Sorokin (ftl)
Dmitry, please review
5 years, 10 months ago (2015-01-29 12:08:15 UTC) #2
Roman Sorokin (ftl)
Dmitry, please review. Hi Daniel, please review chromeos/chromeos_switches.h chromeos/chromeos_switches.cc as owner.
5 years, 10 months ago (2015-01-29 13:07:42 UTC) #4
Daniel Erat
lgtm for chromeos/ https://codereview.chromium.org/878913003/diff/20001/chromeos/chromeos_switches.cc File chromeos/chromeos_switches.cc (right): https://codereview.chromium.org/878913003/diff/20001/chromeos/chromeos_switches.cc#newcode286 chromeos/chromeos_switches.cc:286: const char kGaiaEndpoint[] = "gaia-endpoint"; nit: ...
5 years, 10 months ago (2015-01-29 13:15:54 UTC) #5
Dmitry Polukhin
lgtm https://codereview.chromium.org/878913003/diff/20001/chromeos/chromeos_switches.cc File chromeos/chromeos_switches.cc (right): https://codereview.chromium.org/878913003/diff/20001/chromeos/chromeos_switches.cc#newcode286 chromeos/chromeos_switches.cc:286: const char kGaiaEndpoint[] = "gaia-endpoint"; Please rename it ...
5 years, 10 months ago (2015-01-29 13:27:08 UTC) #6
Roman Sorokin (ftl)
https://codereview.chromium.org/878913003/diff/20001/chromeos/chromeos_switches.cc File chromeos/chromeos_switches.cc (right): https://codereview.chromium.org/878913003/diff/20001/chromeos/chromeos_switches.cc#newcode286 chromeos/chromeos_switches.cc:286: const char kGaiaEndpoint[] = "gaia-endpoint"; On 2015/01/29 13:15:54, Daniel ...
5 years, 10 months ago (2015-01-29 13:39:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878913003/40001
5 years, 10 months ago (2015-01-29 13:40:13 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-01-29 14:16:25 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 14:17:27 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/b4e20306b4956cd00a29e7b2b379099897d06826
Cr-Commit-Position: refs/heads/master@{#313700}

Powered by Google App Engine
This is Rietveld 408576698