Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 878913002: Let release scripts determine version based on tags. (Closed)

Created:
5 years, 11 months ago by Michael Achenbach
Modified:
5 years, 10 months ago
Reviewers:
tandrii(chromium)
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Let release scripts determine version based on tags. Also create new v8 versions based on the roll ref, which has some more verification steps than the candidate ref. Improve bailout regarding existing versions. Only create a new version if the revisions is in the future. BUG=chromium:451975 TBR=tandrii@chromium.org NOTRY=true LOG=n Committed: https://crrev.com/c071f4fbb68a8ecafa767ca5ca6f1e2c248f18cf Cr-Commit-Position: refs/heads/master@{#26303}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Remove unused method. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -136 lines) Patch
M tools/release/auto_push.py View 3 chunks +12 lines, -19 lines 0 comments Download
M tools/release/auto_roll.py View 2 chunks +16 lines, -15 lines 0 comments Download
M tools/release/chromium_roll.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/release/common_includes.py View 1 2 chunks +39 lines, -17 lines 0 comments Download
M tools/release/push_to_candidates.py View 4 chunks +12 lines, -41 lines 0 comments Download
M tools/release/test_scripts.py View 7 chunks +29 lines, -41 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
PTAL https://codereview.chromium.org/878913002/diff/1/tools/release/common_includes.py File tools/release/common_includes.py (left): https://codereview.chromium.org/878913002/diff/1/tools/release/common_includes.py#oldcode602 tools/release/common_includes.py:602: if len(version_parts) == 3: This was a mistake. ...
5 years, 11 months ago (2015-01-27 11:39:04 UTC) #2
tandrii(chromium)
lgtm
5 years, 11 months ago (2015-01-28 00:07:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878913002/20001
5 years, 10 months ago (2015-01-28 10:08:48 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-28 10:09:01 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 10:09:12 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c071f4fbb68a8ecafa767ca5ca6f1e2c248f18cf
Cr-Commit-Position: refs/heads/master@{#26303}

Powered by Google App Engine
This is Rietveld 408576698