build_apprtc_closure.py - Issue 878903003: Retry npm calls since they seem a bit unreliable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build_apprtc_closure.py

Issue 878903003: Retry npm calls since they seem a bit unreliable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/webrtc/webrtc.DEPS/

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build_apprtc_closure.py

===================================================================

--- build_apprtc_closure.py (revision 293821)

+++ build_apprtc_closure.py (working copy)

@@ -11,7 +11,6 @@

import os

import shutil

-import subprocess

import sys

import utils

@@ -34,7 +33,7 @@

npm_bin = os.path.join(node_path, 'bin', 'npm')

node_bin = os.path.join(node_path, 'bin', 'node')

- subprocess.check_call([npm_bin, 'install'])

+ utils.RunSubprocessWithRetry([npm_bin, 'install'])

local_grunt_bin = os.path.join('node_modules', 'grunt-cli', 'bin', 'grunt')

if not os.path.exists(local_grunt_bin):

@@ -41,7 +40,8 @@

return ('Missing grunt-cli in the webrtc-samples checkout; did '

'npm install fail?')

- subprocess.check_call([node_bin, local_grunt_bin, 'closurecompiler:debug'])

+ utils.RunSubprocessWithRetry([node_bin, local_grunt_bin,

+ 'closurecompiler:debug'])

if __name__ == '__main__':

« no previous file with comments | « no previous file | utils.py » ('j') | no next file with comments »