Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1600)

Issue 878883002: Dart: Adjusts class Application for removal of Application/Shell Client= (Closed)

Created:
5 years, 10 months ago by zra
Modified:
5 years, 10 months ago
Reviewers:
abarth-chromium
CC:
Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), Elliot Glaysher, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Dart: Adjusts class Application for removal of Application/Shell Client= In the change https://codereview.chromium.org/868463008/ Application and Shell are no longer clients of each other. This CL fixes Dart's now broken application library to match the new interfaces. Also: - Fixes a name conflict in bindings generation, - Makes Application.stubFactoryClosure() abstract - Renames shellHandle -> appHandle. BUG= R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d8bbf58af38dbd16685fd75c2153b9ea6e67e181

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -39 lines) Patch
M examples/dart/wget.dart View 2 chunks +6 lines, -3 lines 0 comments Download
M mojo/public/dart/application.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/dart/src/application.dart View 1 3 chunks +64 lines, -26 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_dart_generator.py View 1 chunk +1 line, -1 line 0 comments Download
M services/dart/test/echo.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M services/dart/test/pingpong.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M services/dart/test/pingpong_target.dart View 3 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
zra
Following this, I don't believe there is any Dart code using interfaces that still have ...
5 years, 10 months ago (2015-01-27 15:43:35 UTC) #2
abarth-chromium
lgtm
5 years, 10 months ago (2015-01-27 17:33:45 UTC) #3
abarth-chromium
On 2015/01/27 at 15:43:35, zra wrote: > Following this, I don't believe there is any ...
5 years, 10 months ago (2015-01-27 17:33:51 UTC) #4
zra
5 years, 10 months ago (2015-01-27 17:55:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d8bbf58af38dbd16685fd75c2153b9ea6e67e181 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698