Source/core/animation/StringKeyframe.cpp - Issue 878863002: Animation: Add CSSPropertyClip and CSSPropertyBorderImageSlice to StringKeyframe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/StringKeyframe.cpp

Issue 878863002: Animation: Add CSSPropertyClip and CSSPropertyBorderImageSlice to StringKeyframe (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Handling auto values Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/animation/LengthBoxStyleInterpolationTest.cpp ('K') | « Source/core/animation/LengthBoxStyleInterpolationTest.cpp ('k') | Source/core/css/CSSBorderImageSliceValue.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/StringKeyframe.cpp

diff --git a/Source/core/animation/StringKeyframe.cpp b/Source/core/animation/StringKeyframe.cpp

index 71ae40ad7a98b392ce95e40097d7a1073ac4c83e..a614eb6fd9ce1d2956da76e4f135a900b0cf66bd 100644

--- a/Source/core/animation/StringKeyframe.cpp

+++ b/Source/core/animation/StringKeyframe.cpp

@@ -246,12 +246,9 @@ PassRefPtrWillBeRawPtr<Interpolation> StringKeyframe::PropertySpecificKeyframe::

fallBackToLegacy = true;

break;

}

- case CSSPropertyWebkitMaskBoxImageSlice:

- if (LengthBoxStyleInterpolation::matchingFill(*toCSSValue, *fromCSSValue) && LengthBoxStyleInterpolation::canCreateFrom(*fromCSSValue) && LengthStyleInterpolation::canCreateFrom(*toCSSValue))

- return LengthBoxStyleInterpolation::createFromBorderImageSlice(*fromCSSValue, *toCSSValue, property);

- break;

case CSSPropertyTransform: {

if (TransformStyleInterpolation::fallBackToLegacy(*fromCSSValue, *toCSSValue)) {

// FIXME: Handle matrices and interpolating to/from CSSValueNone from/to CSSValueList

@@ -264,6 +261,16 @@ PassRefPtrWillBeRawPtr<Interpolation> StringKeyframe::PropertySpecificKeyframe::

break;

}

+ case CSSPropertyClip:

+ case CSSPropertyBorderImageSlice:

+ case CSSPropertyWebkitMaskBoxImageSlice:

+ {

Eric Willigers 2015/02/11 03:56:32 Move brace to end of previous line.

jadeg 2015/02/12 05:06:00 Done.

+ RefPtrWillBeRawPtr<Interpolation> interpolation = LengthBoxStyleInterpolation::maybeCreateFrom(fromCSSValue, toCSSValue, property);

+ if (interpolation)

+ return interpolation.release();

+ break;

+ }

Eric Willigers 2015/02/11 03:56:32 This brace and the preceding lines can be unindent

jadeg 2015/02/12 05:06:00 Done.

case CSSPropertyStrokeWidth:

range = RangeNonNegative;

// Fall through