Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 878843003: Support enums in dart2dart. (Closed)

Created:
5 years, 11 months ago by Johnni Winther
Modified:
5 years, 10 months ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -25 lines) Patch
M pkg/analyzer2dart/lib/src/modely.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend.dart View 2 chunks +1 line, -4 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend_ast_to_frontend_ast.dart View 3 chunks +11 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/outputter.dart View 1 8 chunks +35 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/placeholder_collector.dart View 1 chunk +8 lines, -0 lines 0 comments Download
A + tests/language/enum_duplicate_lib.dart View 1 1 chunk +7 lines, -4 lines 0 comments Download
A tests/language/enum_duplicate_test.dart View 1 1 chunk +34 lines, -0 lines 0 comments Download
A tests/language/enum_index_test.dart View 1 chunk +32 lines, -0 lines 0 comments Download
A + tests/language/enum_private_lib.dart View 1 chunk +5 lines, -6 lines 0 comments Download
A tests/language/enum_private_test.dart View 1 chunk +27 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language_analyzer.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Johnni Winther
5 years, 11 months ago (2015-01-27 11:39:13 UTC) #2
sigurdm
https://codereview.chromium.org/878843003/diff/1/tests/language/language_dart2js.status File tests/language/language_dart2js.status (right): https://codereview.chromium.org/878843003/diff/1/tests/language/language_dart2js.status#newcode212 tests/language/language_dart2js.status:212: enum_duplicate_test/01: CompileTimeError # Issue 22169 This compiletimeerror error could ...
5 years, 11 months ago (2015-01-27 13:16:06 UTC) #3
Johnni Winther
PTAL https://codereview.chromium.org/878843003/diff/1/tests/language/language_dart2js.status File tests/language/language_dart2js.status (right): https://codereview.chromium.org/878843003/diff/1/tests/language/language_dart2js.status#newcode212 tests/language/language_dart2js.status:212: enum_duplicate_test/01: CompileTimeError # Issue 22169 On 2015/01/27 13:16:06, ...
5 years, 11 months ago (2015-01-27 15:01:49 UTC) #4
sigurdm
lgtm
5 years, 11 months ago (2015-01-28 08:28:21 UTC) #5
Johnni Winther
5 years, 10 months ago (2015-01-28 09:05:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43230 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698