Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 878843002: Revert of Add ChannelPosix::ResetSafely() to deal with a lingering crash (Closed)

Created:
5 years, 11 months ago by yoichio
Modified:
5 years, 11 months ago
Reviewers:
Hajime Morrita, agl, jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add ChannelPosix::ResetSafely() to deal with a lingering crash (patchset #1 id:1 of https://codereview.chromium.org/882543002/) Reason for revert: many ipc test failed. https://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/10036 Original issue's description: > Add ChannelPosix::ResetSafely() to deal with a lingering crash > > The CL [1] tightened the error check too much and revealed > an existing inconsistency and resulted a production crash. > This CL makes a workaround to that crash, turning a PCHECK() > to DPCHECK(). > > [1] https://crrev.com/ce44fef5fd60dd2be5c587d4b084bdcd36adcee4 > > BUG=449233, 448245 > R=agl@chromium.org,jam@chromium.org > > Committed: https://crrev.com/cf3eae19b456536c5ff8dacf8800ec09f9af4bca > Cr-Commit-Position: refs/heads/master@{#313188} TBR=agl@chromium.org,jam@chromium.org,morrita@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=449233, 448245 Committed: https://crrev.com/b83c03c7b691914a054abaab13fb9131b4e0152b Cr-Commit-Position: refs/heads/master@{#313226}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -24 lines) Patch
M ipc/ipc_channel_posix.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ipc/ipc_channel_posix.cc View 4 chunks +1 line, -20 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yoichio
Created Revert of Add ChannelPosix::ResetSafely() to deal with a lingering crash
5 years, 11 months ago (2015-01-27 04:15:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878843002/1
5 years, 11 months ago (2015-01-27 04:15:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-27 04:17:18 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 04:21:41 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b83c03c7b691914a054abaab13fb9131b4e0152b
Cr-Commit-Position: refs/heads/master@{#313226}

Powered by Google App Engine
This is Rietveld 408576698