Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 878793003: [Chromoting] Enable AppRemoting sample apps by default in all.gyp. (Closed)

Created:
5 years, 11 months ago by garykac
Modified:
5 years, 11 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromoting] Enable AppRemoting sample apps by default in all.gyp. Where "by default" = whenever we build Chromoting. BUG= Committed: https://crrev.com/e0bf65f1e2fcd3515b92c1b49f04aa30fd0d47e6 Cr-Commit-Position: refs/heads/master@{#313324}

Patch Set 1 #

Patch Set 2 : Fix "<DEPTH) in app_remoting_webapp.gyp" #

Patch Set 3 : Sync/merge #

Patch Set 4 : Sync/merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
garykac
5 years, 11 months ago (2015-01-27 18:38:14 UTC) #2
scottmg
lgtm
5 years, 11 months ago (2015-01-27 18:40:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878793003/60001
5 years, 11 months ago (2015-01-27 19:34:31 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 11 months ago (2015-01-27 19:39:56 UTC) #6
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/e0bf65f1e2fcd3515b92c1b49f04aa30fd0d47e6 Cr-Commit-Position: refs/heads/master@{#313324}
5 years, 11 months ago (2015-01-27 19:41:11 UTC) #7
brettw
5 years, 11 months ago (2015-01-27 20:29:26 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/880083002/ by brettw@chromium.org.

The reason for reverting is: Broke the official builders:
Traceback (most recent call last):
  File "../remoting/webapp/build-webapp.py", line 413, in <module>
    sys.exit(main())
  File "../remoting/webapp/build-webapp.py", line 409, in main
    service_environment)
  File "../remoting/webapp/build-webapp.py", line 198, in buildWebApp
    + buildtype + ': ' + service_environment)
Exception: Invalid service_environment targeted for Official: dev
ninja: build stopped: subcommand failed.

http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%....

Powered by Google App Engine
This is Rietveld 408576698