Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 878793002: Add CopyTexSubImage3D to GPU command buffer. (Closed)

Created:
5 years, 11 months ago by Zhenyao Mo
Modified:
5 years, 10 months ago
Reviewers:
piman
CC:
chromium-reviews, Ken Russell (switch to Gerrit), bajones, no sievers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add CopyTexSubImage3D to GPU command buffer. BUG=429053 TEST=gpu_unittests R=piman@chromium.org NOTRY=true Committed: https://crrev.com/66f3677cddf1524f3dde9107c9aa9be1e432b911 Cr-Commit-Position: refs/heads/master@{#313380}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+535 lines, -284 lines) Patch
M gpu/GLES2/gl2chromium_autogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 2 chunks +24 lines, -12 lines 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 2 chunks +16 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_cmd_helper_autogen.h View 1 chunk +16 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 1 chunk +10 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_impl_autogen.h View 1 chunk +28 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest_autogen.h View 1 chunk +11 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_autogen.h View 1 chunk +9 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_autogen.h View 1 chunk +9 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h View 1 chunk +10 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_autogen.h View 1 chunk +9 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h View 1 chunk +14 lines, -0 lines 0 comments Download
M gpu/command_buffer/cmd_buffer_functions.txt View 3 chunks +4 lines, -3 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_autogen.h View 1 chunk +83 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_test_autogen.h View 1 chunk +22 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_ids_autogen.h View 1 chunk +227 lines, -226 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 6 chunks +26 lines, -39 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_1_autogen.h View 2 chunks +12 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_3_autogen.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Zhenyao Mo
piman: please review. This is a straightforward command to add. I also removed the size ...
5 years, 11 months ago (2015-01-27 17:38:43 UTC) #6
piman
lgtm
5 years, 11 months ago (2015-01-27 21:44:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878793002/100001
5 years, 11 months ago (2015-01-27 21:49:53 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/27601)
5 years, 10 months ago (2015-01-27 22:28:15 UTC) #11
Zhenyao Mo
Failure is irrelevant. Land with NOTRY=true
5 years, 10 months ago (2015-01-27 22:30:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878793002/100001
5 years, 10 months ago (2015-01-27 22:31:13 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:100001)
5 years, 10 months ago (2015-01-27 22:34:00 UTC) #15
commit-bot: I haz the power
5 years, 10 months ago (2015-01-27 22:34:44 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/66f3677cddf1524f3dde9107c9aa9be1e432b911
Cr-Commit-Position: refs/heads/master@{#313380}

Powered by Google App Engine
This is Rietveld 408576698