Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 878773002: Add a test for mime handler view iframes and make them work on Windows. (Closed)

Created:
5 years, 11 months ago by Sam McNally
Modified:
5 years, 10 months ago
Reviewers:
raymes
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a test for mime handler view iframes and make them work on Windows. Committed: https://crrev.com/36a8048b97fd720153b0474bac36a8a3387f6d8f Cr-Commit-Position: refs/heads/master@{#313436}

Patch Set 1 : #

Total comments: 6

Patch Set 2 : rebase #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -166 lines) Patch
M chrome/chrome_tests.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/mime_handler_view/embedded.js View 1 2 4 chunks +71 lines, -28 lines 0 comments Download
M chrome/test/data/extensions/api_test/mime_handler_view/manifest.json View 1 chunk +1 line, -13 lines 0 comments Download
D chrome/test/data/extensions/api_test/mime_handler_view/test.csv View 1 chunk +0 lines, -1 line 0 comments Download
A chrome/test/data/extensions/api_test/mime_handler_view/testAbort.csv.mock-http-headers View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/mime_handler_view/testBasic.csv.mock-http-headers View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/mime_handler_view/testEmbedded.csv.mock-http-headers View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/mime_handler_view/testIframe.csv View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/mime_handler_view/testIframe.csv.mock-http-headers View 1 chunk +2 lines, -0 lines 0 comments Download
A + chrome/test/data/extensions/api_test/mime_handler_view/testPostMessage.csv View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/extensions/api_test/mime_handler_view/testPostMessage.csv.mock-http-headers View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/mime_handler_view/test_embedded.html View 1 chunk +1 line, -1 line 0 comments Download
A chrome/test/data/extensions/api_test/mime_handler_view/test_iframe.html View 1 chunk +6 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/mime_handler_view/test_iframe.js View 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/mime_handler_view/test_postmessage.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/mime_handler_view/test_postmessage.js View 1 2 1 chunk +22 lines, -26 lines 0 comments Download
A + extensions/browser/guest_view/mime_handler_view/mime_handler_view_browsertest.cc View 3 chunks +17 lines, -22 lines 0 comments Download
D extensions/renderer/guest_view/mime_handler_view/mime_handler_view_browsertest.cc View 1 chunk +0 lines, -74 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
Sam McNally
5 years, 11 months ago (2015-01-27 06:47:11 UTC) #5
raymes
lgtm, thanks! https://codereview.chromium.org/878773002/diff/60001/chrome/test/data/extensions/api_test/mime_handler_view/embedded.js File chrome/test/data/extensions/api_test/mime_handler_view/embedded.js (right): https://codereview.chromium.org/878773002/diff/60001/chrome/test/data/extensions/api_test/mime_handler_view/embedded.js#newcode7 chrome/test/data/extensions/api_test/mime_handler_view/embedded.js:7: var queuedMessages = []; nit: Please add ...
5 years, 10 months ago (2015-01-28 00:54:59 UTC) #6
raymes
https://codereview.chromium.org/878773002/diff/60001/chrome/test/data/extensions/api_test/mime_handler_view/test_postmessage.js File chrome/test/data/extensions/api_test/mime_handler_view/test_postmessage.js (right): https://codereview.chromium.org/878773002/diff/60001/chrome/test/data/extensions/api_test/mime_handler_view/test_postmessage.js#newcode13 chrome/test/data/extensions/api_test/mime_handler_view/test_postmessage.js:13: plugin.postMessage('succeed'); Maybe we should comment on this as well ...
5 years, 10 months ago (2015-01-28 01:02:36 UTC) #7
Sam McNally
https://codereview.chromium.org/878773002/diff/60001/chrome/test/data/extensions/api_test/mime_handler_view/embedded.js File chrome/test/data/extensions/api_test/mime_handler_view/embedded.js (right): https://codereview.chromium.org/878773002/diff/60001/chrome/test/data/extensions/api_test/mime_handler_view/embedded.js#newcode7 chrome/test/data/extensions/api_test/mime_handler_view/embedded.js:7: var queuedMessages = []; On 2015/01/28 00:54:58, raymes wrote: ...
5 years, 10 months ago (2015-01-28 01:54:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878773002/120001
5 years, 10 months ago (2015-01-28 01:55:18 UTC) #11
raymes
lgtm
5 years, 10 months ago (2015-01-28 01:59:10 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/27843)
5 years, 10 months ago (2015-01-28 02:55:00 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878773002/120001
5 years, 10 months ago (2015-01-28 02:57:47 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:120001)
5 years, 10 months ago (2015-01-28 04:16:30 UTC) #17
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 04:18:18 UTC) #18
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/36a8048b97fd720153b0474bac36a8a3387f6d8f
Cr-Commit-Position: refs/heads/master@{#313436}

Powered by Google App Engine
This is Rietveld 408576698